You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "szetszwo (via GitHub)" <gi...@apache.org> on 2023/09/19 15:36:42 UTC

[GitHub] [ratis] szetszwo commented on pull request #921: RATIS-1890. SegmentedRaftLogCache#shouldEvict should only iterate over closed segments once

szetszwo commented on PR #921:
URL: https://github.com/apache/ratis/pull/921#issuecomment-1725907283

   > If not, shall we consider making this eviction operation less frequent?
   
   We do eviction only if there is a violation.
   
   https://github.com/apache/ratis/blob/05f39221102abc00b2934e279da872d06f6a1811/ratis-server/src/main/java/org/apache/ratis/server/raftlog/segmented/SegmentedRaftLogCache.java#L418-L420
   
   I suspect the current `CacheInvalidationPolicyDefault` is inefficient -- the code looks complicated.  We may make the operation async.  Then, it won't affect the append operation.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org