You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@struts.apache.org by "Jeromy Evans (JIRA)" <ji...@apache.org> on 2007/12/31 07:23:34 UTC

[jira] Created: (WW-2398) AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context

AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context
-----------------------------------------------------------------------------

                 Key: WW-2398
                 URL: https://issues.apache.org/struts/browse/WW-2398
             Project: Struts 2
          Issue Type: Bug
          Components: Plugin - Dojo Tags
    Affects Versions: 2.1.0
            Reporter: Jeromy Evans
            Priority: Minor


The AbstractRemoteBean assumes the Head tag predefines the Head.PARSE_CONTENT parameter in the context.

boolean generateId = !(Boolean)stack.getContext().get(Head.PARSE_CONTENT);

If the AbstractRemoveBean is rendered in a fragment loaded via XHR a Head tag may not be present and an NPE is thrown by !(null)

A patch is proposed that will check for the Null case and assume false if not present.


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WW-2398) AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context

Posted by "Jeromy Evans (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeromy Evans updated WW-2398:
-----------------------------

    Attachment: abstractremotebean.patch

Attached patch checks for a null value prior to the boolean comparison

> AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context
> -----------------------------------------------------------------------------
>
>                 Key: WW-2398
>                 URL: https://issues.apache.org/struts/browse/WW-2398
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Dojo Tags
>    Affects Versions: 2.1.0
>            Reporter: Jeromy Evans
>            Priority: Minor
>         Attachments: abstractremotebean.patch
>
>
> The AbstractRemoteBean assumes the Head tag predefines the Head.PARSE_CONTENT parameter in the context.
> boolean generateId = !(Boolean)stack.getContext().get(Head.PARSE_CONTENT);
> If the AbstractRemoveBean is rendered in a fragment loaded via XHR a Head tag may not be present and an NPE is thrown by !(null)
> A patch is proposed that will check for the Null case and assume false if not present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WW-2398) AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context

Posted by "Jeromy Evans (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/struts/browse/WW-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=43270#action_43270 ] 

Jeromy Evans commented on WW-2398:
----------------------------------

That was going to be my first commit :-(

> AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context
> -----------------------------------------------------------------------------
>
>                 Key: WW-2398
>                 URL: https://issues.apache.org/struts/browse/WW-2398
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Dojo Tags
>    Affects Versions: 2.1.0
>            Reporter: Jeromy Evans
>            Assignee: Don Brown
>            Priority: Minor
>             Fix For: 2.1.1
>
>         Attachments: abstractremotebean.patch
>
>
> The AbstractRemoteBean assumes the Head tag predefines the Head.PARSE_CONTENT parameter in the context.
> boolean generateId = !(Boolean)stack.getContext().get(Head.PARSE_CONTENT);
> If the AbstractRemoveBean is rendered in a fragment loaded via XHR a Head tag may not be present and an NPE is thrown by !(null)
> A patch is proposed that will check for the Null case and assume false if not present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-2398) AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Husted reassigned WW-2398:
------------------------------

    Assignee:     (was: Ted Husted)

> AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context
> -----------------------------------------------------------------------------
>
>                 Key: WW-2398
>                 URL: https://issues.apache.org/struts/browse/WW-2398
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Dojo Tags
>    Affects Versions: 2.1.0
>            Reporter: Jeromy Evans
>            Priority: Minor
>             Fix For: 2.1.1
>
>         Attachments: abstractremotebean.patch
>
>
> The AbstractRemoteBean assumes the Head tag predefines the Head.PARSE_CONTENT parameter in the context.
> boolean generateId = !(Boolean)stack.getContext().get(Head.PARSE_CONTENT);
> If the AbstractRemoveBean is rendered in a fragment loaded via XHR a Head tag may not be present and an NPE is thrown by !(null)
> A patch is proposed that will check for the Null case and assume false if not present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WW-2398) AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context

Posted by "Ted Husted (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Husted reassigned WW-2398:
------------------------------

    Assignee: Ted Husted

> AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context
> -----------------------------------------------------------------------------
>
>                 Key: WW-2398
>                 URL: https://issues.apache.org/struts/browse/WW-2398
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Dojo Tags
>    Affects Versions: 2.1.0
>            Reporter: Jeromy Evans
>            Assignee: Ted Husted
>            Priority: Minor
>             Fix For: 2.1.1
>
>         Attachments: abstractremotebean.patch
>
>
> The AbstractRemoteBean assumes the Head tag predefines the Head.PARSE_CONTENT parameter in the context.
> boolean generateId = !(Boolean)stack.getContext().get(Head.PARSE_CONTENT);
> If the AbstractRemoveBean is rendered in a fragment loaded via XHR a Head tag may not be present and an NPE is thrown by !(null)
> A patch is proposed that will check for the Null case and assume false if not present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (WW-2398) AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context

Posted by "Don Brown (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/struts/browse/WW-2398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Don Brown resolved WW-2398.
---------------------------

    Resolution: Fixed
      Assignee: Don Brown

Fixed...you know Jeromy, you can apply your own patches now... :)

> AbstractRemoteBean throws NPE if Head.PARSE_CONTENT is not defined in context
> -----------------------------------------------------------------------------
>
>                 Key: WW-2398
>                 URL: https://issues.apache.org/struts/browse/WW-2398
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Plugin - Dojo Tags
>    Affects Versions: 2.1.0
>            Reporter: Jeromy Evans
>            Assignee: Don Brown
>            Priority: Minor
>             Fix For: 2.1.1
>
>         Attachments: abstractremotebean.patch
>
>
> The AbstractRemoteBean assumes the Head tag predefines the Head.PARSE_CONTENT parameter in the context.
> boolean generateId = !(Boolean)stack.getContext().get(Head.PARSE_CONTENT);
> If the AbstractRemoveBean is rendered in a fragment loaded via XHR a Head tag may not be present and an NPE is thrown by !(null)
> A patch is proposed that will check for the Null case and assume false if not present.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.