You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/25 07:38:58 UTC
[GitHub] [incubator-superset] blcksrx opened a new pull request #10425: fix: db installation
blcksrx opened a new pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
It's not a really good idea to pass the DB installation to the user without specifying a goo version, Also the best practice is providing the extras on the `extras_require`
In addition this PR, depends on this PR:
https://github.com/apache/incubator-superset/pull/10407
Because there's no way to pass the git link to the extras_require
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#discussion_r464828226
##########
File path: docs/installation.rst
##########
@@ -482,72 +482,67 @@ connect to the databases you want to access through Superset.
Here's a list of some of the recommended packages.
-+------------------+---------------------------------------+-------------------------------------------------+
-| database | pypi package | SQLAlchemy URI prefix |
-+==================+=======================================+=================================================+
-| Amazon Athena | ``pip install "PyAthenaJDBC>1.0.9"`` | ``awsathena+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Athena | ``pip install "PyAthena>1.2.0"`` | ``awsathena+rest://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Redshift | ``pip install sqlalchemy-redshift`` | ``redshift+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Drill | ``pip install sqlalchemy-drill`` | For the REST API:`` |
-| | | ``drill+sadrill://`` |
-| | | For JDBC |
-| | | ``drill+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Druid | ``pip install pydruid`` | ``druid://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Hive | ``pip install pyhive`` | ``hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Impala | ``pip install impyla`` | ``impala://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Kylin | ``pip install kylinpy`` | ``kylin://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Pinot | ``pip install pinotdb`` | ``pinot+http://CONTROLLER:5436/`` |
-| | | ``query?server=http://CONTROLLER:5983/`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Spark SQL | ``pip install pyhive`` | ``jdbc+hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| BigQuery | ``pip install pybigquery`` | ``bigquery://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| ClickHouse | ``pip install sqlalchemy-clickhouse`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| CockroachDB | ``pip install cockroachdb`` | ``cockroachdb://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Dremio | ``pip install sqlalchemy_dremio`` | ``dremio://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Elasticsearch | ``pip install elasticsearch-dbapi`` | ``elasticsearch+http://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Exasol | ``pip install sqlalchemy-exasol`` | ``exa+pyodbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Google Sheets | ``pip install gsheetsdb`` | ``gsheets://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| IBM Db2 | ``pip install ibm_db_sa`` | ``db2+ibm_db://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| MySQL | ``pip install mysqlclient`` | ``mysql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Oracle | ``pip install cx_Oracle`` | ``oracle://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| PostgreSQL | ``pip install psycopg2`` | ``postgresql+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Presto | ``pip install pyhive`` | ``presto://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Snowflake | ``pip install snowflake-sqlalchemy`` | ``snowflake://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQLite | | ``sqlite://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQL Server | ``pip install pymssql`` | ``mssql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Teradata | ``pip install sqlalchemy-teradata`` | ``teradata://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Vertica | ``pip install | ``vertica+vertica_python://`` |
-| | sqlalchemy-vertica-python`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Hana | ``pip install hdbcli sqlalchemy-hana``| ``hana://`` |
-| | or | |
-| | ``pip install apache-superset[hana]`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| database | pypi package | SQLAlchemy URI prefix |
++==================+===================================================================+=================================================+
+| Amazon Athena | ``pip install "apache-superset[athena]"`` | ``awsathena+jdbc://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Amazon Redshift | ``pip install "apache-superset[redshift]"`` | ``redshift+psycopg2://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Apache Drill | ``pip install "apache-superset[drill]"`` | For the REST API:`` |
+| | | ``drill+sadrill://`` |
+| | | For JDBC |
+| | | ``drill+jdbc://`` |
Review comment:
As long as drill doesn't have an `extras_require` we probably need to state here that there is no PyPI package for drill yet, and just link to the GitHub repo.
##########
File path: docs/installation.rst
##########
@@ -482,72 +482,67 @@ connect to the databases you want to access through Superset.
Here's a list of some of the recommended packages.
-+------------------+---------------------------------------+-------------------------------------------------+
-| database | pypi package | SQLAlchemy URI prefix |
-+==================+=======================================+=================================================+
-| Amazon Athena | ``pip install "PyAthenaJDBC>1.0.9"`` | ``awsathena+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Athena | ``pip install "PyAthena>1.2.0"`` | ``awsathena+rest://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Redshift | ``pip install sqlalchemy-redshift`` | ``redshift+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Drill | ``pip install sqlalchemy-drill`` | For the REST API:`` |
-| | | ``drill+sadrill://`` |
-| | | For JDBC |
-| | | ``drill+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Druid | ``pip install pydruid`` | ``druid://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Hive | ``pip install pyhive`` | ``hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Impala | ``pip install impyla`` | ``impala://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Kylin | ``pip install kylinpy`` | ``kylin://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Pinot | ``pip install pinotdb`` | ``pinot+http://CONTROLLER:5436/`` |
-| | | ``query?server=http://CONTROLLER:5983/`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Spark SQL | ``pip install pyhive`` | ``jdbc+hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| BigQuery | ``pip install pybigquery`` | ``bigquery://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| ClickHouse | ``pip install sqlalchemy-clickhouse`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| CockroachDB | ``pip install cockroachdb`` | ``cockroachdb://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Dremio | ``pip install sqlalchemy_dremio`` | ``dremio://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Elasticsearch | ``pip install elasticsearch-dbapi`` | ``elasticsearch+http://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Exasol | ``pip install sqlalchemy-exasol`` | ``exa+pyodbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Google Sheets | ``pip install gsheetsdb`` | ``gsheets://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| IBM Db2 | ``pip install ibm_db_sa`` | ``db2+ibm_db://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| MySQL | ``pip install mysqlclient`` | ``mysql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Oracle | ``pip install cx_Oracle`` | ``oracle://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| PostgreSQL | ``pip install psycopg2`` | ``postgresql+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Presto | ``pip install pyhive`` | ``presto://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Snowflake | ``pip install snowflake-sqlalchemy`` | ``snowflake://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQLite | | ``sqlite://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQL Server | ``pip install pymssql`` | ``mssql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Teradata | ``pip install sqlalchemy-teradata`` | ``teradata://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Vertica | ``pip install | ``vertica+vertica_python://`` |
-| | sqlalchemy-vertica-python`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Hana | ``pip install hdbcli sqlalchemy-hana``| ``hana://`` |
-| | or | |
-| | ``pip install apache-superset[hana]`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| database | pypi package | SQLAlchemy URI prefix |
Review comment:
Let's make the headers uniform:
```suggestion
| Database | PyPI package | SQLAlchemy URI prefix |
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#discussion_r465135724
##########
File path: setup.py
##########
@@ -109,22 +109,36 @@ def get_git_sha():
"wtforms-json",
],
extras_require={
- "athena": ["pyathena>=1.10.8,<1.11"],
- "bigquery": ["pybigquery>=0.4.10", "pandas_gbq>=0.10.0"],
- "cors": ["flask-cors>=2.0.0"],
- "gsheets": ["gsheetsdb>=0.1.9"],
- "hive": ["pyhive[hive]>=0.6.1", "tableschema", "thrift>=0.11.0, <1.0.0"],
- "mysql": ["mysqlclient==1.4.2.post1"],
- "postgres": ["psycopg2-binary==2.8.5"],
- "presto": ["pyhive[presto]>=0.4.0"],
- "elasticsearch": ["elasticsearch-dbapi>=0.1.0, <0.2.0"],
- "druid": ["pydruid>=0.6.1,<0.7"],
- "hana": ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"],
- "dremio": ["sqlalchemy_dremio>=1.1.0"],
- "cockroachdb": ["cockroachdb==0.3.3"],
- "thumbnails": ["Pillow>=7.0.0, <8.0.0"],
- "excel": ["xlrd>=1.2.0, <1.3"],
- "prophet": ["fbprophet>=0.6, <0.7"],
+ {
Review comment:
This should be a `Dict[str, List[str]]` however it’s wrapped in an additional set of `{}` which is causing the CI issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#discussion_r464839330
##########
File path: docs/installation.rst
##########
@@ -482,72 +482,67 @@ connect to the databases you want to access through Superset.
Here's a list of some of the recommended packages.
-+------------------+---------------------------------------+-------------------------------------------------+
-| database | pypi package | SQLAlchemy URI prefix |
-+==================+=======================================+=================================================+
-| Amazon Athena | ``pip install "PyAthenaJDBC>1.0.9"`` | ``awsathena+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Athena | ``pip install "PyAthena>1.2.0"`` | ``awsathena+rest://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Redshift | ``pip install sqlalchemy-redshift`` | ``redshift+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Drill | ``pip install sqlalchemy-drill`` | For the REST API:`` |
-| | | ``drill+sadrill://`` |
-| | | For JDBC |
-| | | ``drill+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Druid | ``pip install pydruid`` | ``druid://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Hive | ``pip install pyhive`` | ``hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Impala | ``pip install impyla`` | ``impala://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Kylin | ``pip install kylinpy`` | ``kylin://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Pinot | ``pip install pinotdb`` | ``pinot+http://CONTROLLER:5436/`` |
-| | | ``query?server=http://CONTROLLER:5983/`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Spark SQL | ``pip install pyhive`` | ``jdbc+hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| BigQuery | ``pip install pybigquery`` | ``bigquery://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| ClickHouse | ``pip install sqlalchemy-clickhouse`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| CockroachDB | ``pip install cockroachdb`` | ``cockroachdb://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Dremio | ``pip install sqlalchemy_dremio`` | ``dremio://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Elasticsearch | ``pip install elasticsearch-dbapi`` | ``elasticsearch+http://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Exasol | ``pip install sqlalchemy-exasol`` | ``exa+pyodbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Google Sheets | ``pip install gsheetsdb`` | ``gsheets://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| IBM Db2 | ``pip install ibm_db_sa`` | ``db2+ibm_db://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| MySQL | ``pip install mysqlclient`` | ``mysql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Oracle | ``pip install cx_Oracle`` | ``oracle://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| PostgreSQL | ``pip install psycopg2`` | ``postgresql+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Presto | ``pip install pyhive`` | ``presto://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Snowflake | ``pip install snowflake-sqlalchemy`` | ``snowflake://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQLite | | ``sqlite://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQL Server | ``pip install pymssql`` | ``mssql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Teradata | ``pip install sqlalchemy-teradata`` | ``teradata://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Vertica | ``pip install | ``vertica+vertica_python://`` |
-| | sqlalchemy-vertica-python`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Hana | ``pip install hdbcli sqlalchemy-hana``| ``hana://`` |
-| | or | |
-| | ``pip install apache-superset[hana]`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| database | pypi package | SQLAlchemy URI prefix |
++==================+===================================================================+=================================================+
+| Amazon Athena | ``pip install "apache-superset[athena]"`` | ``awsathena+jdbc://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Amazon Redshift | ``pip install "apache-superset[redshift]"`` | ``redshift+psycopg2://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Apache Drill | ``pip install "apache-superset[drill]"`` | For the REST API:`` |
+| | | ``drill+sadrill://`` |
+| | | For JDBC |
+| | | ``drill+jdbc://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Apache Druid | ``pip install "apache-superset[druid]"`` | ``druid://`` |
Review comment:
@villebro what are your thoughts about removing the `pip install` prefix here and just mentioning this as a primer, i.e., to install the PyPI package run `pip install <package>`.
##########
File path: setup.py
##########
@@ -120,11 +120,23 @@ def get_git_sha():
"elasticsearch": ["elasticsearch-dbapi>=0.1.0, <0.2.0"],
"druid": ["pydruid>=0.6.1,<0.7"],
"hana": ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"],
- "dremio": ["sqlalchemy_dremio>=1.1.0"],
- "cockroachdb": ["cockroachdb==0.3.3"],
+ "dremio": ["sqlalchemy-dremio>=1.1.5, <1.2"],
Review comment:
Nit @blcksrx would you mind sorting these in alphabetical order? It's easier to grok which engines are supported using this approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch merged pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
mistercrunch merged pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] john-bodley commented on a change in pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
john-bodley commented on a change in pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#discussion_r465135724
##########
File path: setup.py
##########
@@ -109,22 +109,36 @@ def get_git_sha():
"wtforms-json",
],
extras_require={
- "athena": ["pyathena>=1.10.8,<1.11"],
- "bigquery": ["pybigquery>=0.4.10", "pandas_gbq>=0.10.0"],
- "cors": ["flask-cors>=2.0.0"],
- "gsheets": ["gsheetsdb>=0.1.9"],
- "hive": ["pyhive[hive]>=0.6.1", "tableschema", "thrift>=0.11.0, <1.0.0"],
- "mysql": ["mysqlclient==1.4.2.post1"],
- "postgres": ["psycopg2-binary==2.8.5"],
- "presto": ["pyhive[presto]>=0.4.0"],
- "elasticsearch": ["elasticsearch-dbapi>=0.1.0, <0.2.0"],
- "druid": ["pydruid>=0.6.1,<0.7"],
- "hana": ["hdbcli==2.4.162", "sqlalchemy_hana==0.4.0"],
- "dremio": ["sqlalchemy_dremio>=1.1.0"],
- "cockroachdb": ["cockroachdb==0.3.3"],
- "thumbnails": ["Pillow>=7.0.0, <8.0.0"],
- "excel": ["xlrd>=1.2.0, <1.3"],
- "prophet": ["fbprophet>=0.6, <0.7"],
+ {
Review comment:
This should be a `Dict[str, List[str]` however it’s wrapped in an additional set of `{}` which is causing the CI issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] blcksrx commented on pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
blcksrx commented on pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#issuecomment-663825426
Actually I did fix the `black` issue! It would be nice another GitHub workflow for canceling the current job in case of new commit/ force push
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10425: fix: db installation
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10425:
URL: https://github.com/apache/incubator-superset/pull/10425#discussion_r464841617
##########
File path: docs/installation.rst
##########
@@ -482,72 +482,67 @@ connect to the databases you want to access through Superset.
Here's a list of some of the recommended packages.
-+------------------+---------------------------------------+-------------------------------------------------+
-| database | pypi package | SQLAlchemy URI prefix |
-+==================+=======================================+=================================================+
-| Amazon Athena | ``pip install "PyAthenaJDBC>1.0.9"`` | ``awsathena+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Athena | ``pip install "PyAthena>1.2.0"`` | ``awsathena+rest://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Amazon Redshift | ``pip install sqlalchemy-redshift`` | ``redshift+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Drill | ``pip install sqlalchemy-drill`` | For the REST API:`` |
-| | | ``drill+sadrill://`` |
-| | | For JDBC |
-| | | ``drill+jdbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Druid | ``pip install pydruid`` | ``druid://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Hive | ``pip install pyhive`` | ``hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Impala | ``pip install impyla`` | ``impala://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Kylin | ``pip install kylinpy`` | ``kylin://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Pinot | ``pip install pinotdb`` | ``pinot+http://CONTROLLER:5436/`` |
-| | | ``query?server=http://CONTROLLER:5983/`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Apache Spark SQL | ``pip install pyhive`` | ``jdbc+hive://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| BigQuery | ``pip install pybigquery`` | ``bigquery://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| ClickHouse | ``pip install sqlalchemy-clickhouse`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| CockroachDB | ``pip install cockroachdb`` | ``cockroachdb://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Dremio | ``pip install sqlalchemy_dremio`` | ``dremio://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Elasticsearch | ``pip install elasticsearch-dbapi`` | ``elasticsearch+http://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Exasol | ``pip install sqlalchemy-exasol`` | ``exa+pyodbc://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Google Sheets | ``pip install gsheetsdb`` | ``gsheets://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| IBM Db2 | ``pip install ibm_db_sa`` | ``db2+ibm_db://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| MySQL | ``pip install mysqlclient`` | ``mysql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Oracle | ``pip install cx_Oracle`` | ``oracle://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| PostgreSQL | ``pip install psycopg2`` | ``postgresql+psycopg2://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Presto | ``pip install pyhive`` | ``presto://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Snowflake | ``pip install snowflake-sqlalchemy`` | ``snowflake://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQLite | | ``sqlite://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| SQL Server | ``pip install pymssql`` | ``mssql://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Teradata | ``pip install sqlalchemy-teradata`` | ``teradata://`` |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Vertica | ``pip install | ``vertica+vertica_python://`` |
-| | sqlalchemy-vertica-python`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
-| Hana | ``pip install hdbcli sqlalchemy-hana``| ``hana://`` |
-| | or | |
-| | ``pip install apache-superset[hana]`` | |
-+------------------+---------------------------------------+-------------------------------------------------+
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| database | pypi package | SQLAlchemy URI prefix |
++==================+===================================================================+=================================================+
+| Amazon Athena | ``pip install "apache-superset[athena]"`` | ``awsathena+jdbc://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Amazon Redshift | ``pip install "apache-superset[redshift]"`` | ``redshift+psycopg2://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Apache Drill | ``pip install "apache-superset[drill]"`` | For the REST API:`` |
+| | | ``drill+sadrill://`` |
+| | | For JDBC |
+| | | ``drill+jdbc://`` |
++------------------+-------------------------------------------------------------------+-------------------------------------------------+
+| Apache Druid | ``pip install "apache-superset[druid]"`` | ``druid://`` |
Review comment:
I agree @john-bodley , currently it is overly repetitive.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org