You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/12 10:04:48 UTC
[GitHub] [superset] AlmiS opened a new pull request, #21071: Fix remapping of chart ids for crossfilters when importing dashboards
AlmiS opened a new pull request, #21071:
URL: https://github.com/apache/superset/pull/21071
### SUMMARY
When importing a dashboards from another superset instance, the importer will ensure that all chart ids are remapped to the new ids. This includes id's in the dashboard metadata such as filter scopes and native filters.
However, the remapping was not implemented for the cross filters configuration. This PR fixes that.
### TESTING INSTRUCTIONS
Unit test have been added to existing `tests/unit_tests/dashboards/commands/importers/v1/utils_test.py`
Can be tested with `tox -e py38 tests/unit_tests/dashboards/commands/importers/v1/utils_test.py`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] Fix remapping of chart ids for crossfilters when importing dashboards [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #21071:
URL: https://github.com/apache/superset/pull/21071#issuecomment-1924315302
@AlmiS — Sorry this slipped though the cracks for so long! Please feel free to tag committers here or ping us on [Superset Slack](http://bit.ly/join-superset-slack) if things get stuck like this. Is there some interest in rekindling/rebasing this effort?
CC @betodealmeida to assess interest/risk on this idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org