You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "kgabryje (via GitHub)" <gi...@apache.org> on 2024/12/02 13:11:52 UTC
[PR] perf: Optimize native filters and cross filters [superset]
kgabryje opened a new pull request, #31243:
URL: https://github.com/apache/superset/pull/31243
### SUMMARY
This PR supersedes https://github.com/apache/superset/pull/30958.
Optimizes utils and components related to native filters and cross filters. Many util functions, such as `useSelectChartTabParents` or `getCrossFilterIndicator` were suboptimal, running some operations unnecessarily, and were being called from components redundantly. This PR implements memoization in filter bar components, improves Redux selectors and optimizes the util functions.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
For detailed perf improvement results, see the details in PR https://github.com/apache/superset/pull/30958
### TESTING INSTRUCTIONS
No functional changes - the dashboard, native filters, cross filters, chart actions, etc. should work like before
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] perf: Optimize native filters and cross filters [superset]
Posted by "kgabryje (via GitHub)" <gi...@apache.org>.
kgabryje merged PR #31243:
URL: https://github.com/apache/superset/pull/31243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org