You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "Julien (Jira)" <ji...@apache.org> on 2023/06/15 07:35:00 UTC
[jira] [Commented] (FOP-2280) [PATCH] Retrieved marker content ignores writing-mode
[ https://issues.apache.org/jira/browse/FOP-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17732899#comment-17732899 ]
Julien commented on FOP-2280:
-----------------------------
We successfully integrated this patch on our side with a small modification in {{BidiResolver}}:
{code:java}
/**
* Resolve inline directionality.
* @param ps a page sequence FO instance
*/
public static void resolveInlineDirectionality(PageSequence ps) {
resolveInlineDirectionality(ps, new Stack());
}
/**
* Resolve inline directionality.
* @param fObj an object FO instance
* @param rangesStack a stack of delimited text ranges
*/
public static void resolveInlineDirectionality(FONode fObj, Stack rangesStack) {
if (log.isDebugEnabled()) {
log.debug("BD: RESOLVE: " + fObj);
}
// 1. collect delimited text ranges
List ranges = fObj.collectDelimitedTextRanges(rangesStack);
if (log.isDebugEnabled()) {
dumpRanges("BD: RESOLVE: RANGES:", ranges);
}
// 2. prune empty ranges
ranges = pruneEmptyRanges(ranges);
if (log.isDebugEnabled()) {
dumpRanges("BD: RESOLVE: PRUNED RANGES:", ranges);
}
// 3. resolve inline directionaly of unpruned ranges
resolveInlineDirectionality(ranges);
}
{code}
> [PATCH] Retrieved marker content ignores writing-mode
> -----------------------------------------------------
>
> Key: FOP-2280
> URL: https://issues.apache.org/jira/browse/FOP-2280
> Project: FOP
> Issue Type: Bug
> Components: layout/unqualified
> Reporter: Matthias Reischenbacher
> Priority: Major
> Attachments: 2280_hebrew_marker.patch, hebrew_marker.pdf, hebrew_marker.xml
>
>
> Retrieve-marker inside static content ignores current writing-mode. See sample fo file and current PDF output.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)