You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/07/02 00:03:09 UTC

[GitHub] [accumulo] keith-turner opened a new pull request, #2798: checks if file already exists in accumulo-cluster create-config

keith-turner opened a new pull request, #2798:
URL: https://github.com/apache/accumulo/pull/2798

   I was playing around with the `accumulo-cluster create-config` command and accidentally blew my config away.  Thinking it would be best if this command only created the file if didn't exists.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] dlmarion commented on a diff in pull request #2798: checks if file already exists in accumulo-cluster create-config

Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2798:
URL: https://github.com/apache/accumulo/pull/2798#discussion_r913699633


##########
assemble/bin/accumulo-cluster:
##########
@@ -429,6 +429,10 @@ function main() {
 
   case "$1" in
     create-config)
+      if [[ -f "$conf"/cluster.yaml ]]; then
+         echo "ERROR : $conf/cluster.yaml already exists, not overwriting"
+         exit 1
+      fi

Review Comment:
   ```suggestion
         if [[ -f "$conf"/cluster.yaml ]]; then
           echo "ERROR : $conf/cluster.yaml already exists, not overwriting"
           exit 1
         fi
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] dlmarion merged pull request #2798: checks if file already exists in accumulo-cluster create-config

Posted by GitBox <gi...@apache.org>.
dlmarion merged PR #2798:
URL: https://github.com/apache/accumulo/pull/2798


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [accumulo] dlmarion commented on a diff in pull request #2798: checks if file already exists in accumulo-cluster create-config

Posted by GitBox <gi...@apache.org>.
dlmarion commented on code in PR #2798:
URL: https://github.com/apache/accumulo/pull/2798#discussion_r913700038


##########
assemble/bin/accumulo-cluster:
##########
@@ -429,6 +429,10 @@ function main() {
 
   case "$1" in
     create-config)
+      if [[ -f "$conf"/cluster.yaml ]]; then
+         echo "ERROR : $conf/cluster.yaml already exists, not overwriting"
+         exit 1
+      fi

Review Comment:
   Looks like there are 3 spaces vs 2.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org