[GitHub] sanha commented on a change in pull request #102: [NEMO-180] Java Annotation for Prerequisite Execution Properties

[GitBox <gi...@apache.org>]

sanha commented on a change in pull request #102: [NEMO-180] Java Annotation for Prerequisite Execution Properties
URL: https://github.com/apache/incubator-nemo/pull/102#discussion_r210848624
 
 

 ##########
 File path: compiler/optimizer/src/main/java/edu/snu/nemo/compiler/optimizer/pass/compiletime/annotating/AnnotatingPass.java
 ##########
 @@ -17,42 +17,38 @@
 
 import edu.snu.nemo.common.ir.executionproperty.ExecutionProperty;
 import edu.snu.nemo.compiler.optimizer.pass.compiletime.CompileTimePass;
+import edu.snu.nemo.compiler.optimizer.pass.compiletime.Requires;
 
-import java.util.Collections;
+import java.util.Arrays;
+import java.util.HashSet;
 import java.util.Set;
 
 /**
  * A compile-time pass that annotates the IR DAG with execution properties.
  * It is ensured by the compiler that the shape of the IR DAG itself is not modified by an AnnotatingPass.
  */
 public abstract class AnnotatingPass extends CompileTimePass {
-  private final Class<? extends ExecutionProperty> keyOfExecutionPropertyToModify;
+  private final Set<Class<? extends ExecutionProperty>> keyOfExecutionPropertyToModify;
 
 Review comment:
   Why is this key?
   At first, it is not a key but the actual execution property.
   Also, it is a set now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services