You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/04/23 04:13:44 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4694: Provide Meter(metrics) system
wu-sheng opened a new pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694
Hi dev
This pull request introduces the meter system into the SkyWalking core. Meter system is compatible with any metrics system in theory. It shares the same streaming calculation core and still pluggable to different protocols and different metrics read modes(pull/push, grpc/http/mq).
Here are the basic and simple usages of the MeterSystem APIs.
## Meter Creation
New meter could be created based on metrics name, function, scope and data type.
1. Metrics name is still the storage entity name.
1. Functions are every similar with the OAL function, just accepting different input.
```java
final MeterSystem meterSystem = MeterSystem.meterSystem(getManager());
meterSystem.create("test_long_metrics", "avg", ScopeType.SERVICE, Long.class);
```
NOTICE, this creation should only be called in the `module#prepare` stage, otherwise, `Can't create new metrics anymore` exception will be raised after the storage model has begun to install storage entities. You may find, there is a chance `create` could be executed successfully in the `module#start` stage, but it it just because of the sequence of provider loaded by the class loader, **no guarantee, so please don't do that**.
## Runtime Calculation
`AcceptableValue` is the object created at the runtime to accept new metrics value.
```java
final MeterSystem service = getManager().find(CoreModule.NAME).provider().getService(MeterSystem.class);
Executors.newSingleThreadScheduledExecutor().scheduleAtFixedRate(new Runnable() {
@Override
public void run() {
final AcceptableValue<Long> value = service.buildMetrics("test_long_metrics", Long.class);
value.accept(MeterEntity.newService("abc"), 5L);
value.setTimeBucket(TimeBucket.getMinuteTimeBucket(System.currentTimeMillis()));
service.doStreamingCalculation(value);
}
}, 2, 2, TimeUnit.SECONDS);
```
## Meter Functions
Right now, only `avg` function has been implemented. I submit this PR as soon as possible to get your feedback. I will add more functions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `23.28%`.
> The diff coverage is `1.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.31% 28.03% -23.29%
=============================================
Files 1276 1218 -58
Lines 27692 26738 -954
Branches 3004 3320 +316
=============================================
- Hits 14211 7496 -6715
- Misses 12838 18565 +5727
- Partials 643 677 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-80.92%)` | `0.00 <0.00> (-8.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-4.00)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-88.53%)` | `0.00 <0.00> (-9.00)` | |
| [...her/prometheus/module/PrometheusFetcherModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9tb2R1bGUvUHJvbWV0aGV1c0ZldGNoZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [608 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...274cdcb](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `5.60%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 45.44% -5.61%
+ Complexity 2667 2410 -257
============================================
Files 721 703 -18
Lines 17761 17367 -394
Branches 1708 1651 -57
============================================
- Hits 9067 7892 -1175
- Misses 7962 8810 +848
+ Partials 732 665 -67
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [112 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 158 -564
Lines 17800 3830 -13970
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3830 -4150
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [679 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/776d508018daf342931df9111d1fd19836e683a8&el=desc) will **decrease** coverage by `50.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 50.93% 0.00% -50.94%
============================================
Files 722 152 -570
Lines 17800 3731 -14069
Branches 1709 444 -1265
============================================
- Hits 9066 0 -9066
+ Misses 7999 3731 -4268
+ Partials 735 0 -735
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [684 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [776d508...a9ca06b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 148 -1128
Lines 27692 3683 -24009
Branches 3004 437 -2567
============================================
- Hits 14211 0 -14211
+ Misses 12838 3683 -9155
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1244 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...7374c76](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.92%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 49.46% -1.93%
+ Complexity 2668 2644 -24
============================================
Files 1275 727 -548
Lines 27659 17955 -9704
Branches 3003 1722 -1281
============================================
- Hits 14215 8882 -5333
+ Misses 12801 8339 -4462
- Partials 643 734 +91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [880 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 149 -1127
Lines 27692 3710 -23982
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3710 -9128
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 152 -1124
Lines 27692 3731 -23961
Branches 3004 444 -2560
============================================
- Hits 14211 0 -14211
+ Misses 12838 3731 -9107
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1244 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...7374c76](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `23.28%`.
> The diff coverage is `1.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.31% 28.03% -23.29%
=============================================
Files 1276 1218 -58
Lines 27692 26737 -955
Branches 3004 3321 +317
=============================================
- Hits 14211 7496 -6715
- Misses 12838 18564 +5726
- Partials 643 677 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-80.92%)` | `0.00 <0.00> (-8.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-4.00)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-88.53%)` | `0.00 <0.00> (-9.00)` | |
| [...her/prometheus/module/PrometheusFetcherModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9tb2R1bGUvUHJvbWV0aGV1c0ZldGNoZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [609 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...65feb8f](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.92%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 49.46% -1.93%
+ Complexity 2668 2644 -24
============================================
Files 1275 727 -548
Lines 27659 17955 -9704
Branches 3003 1722 -1281
============================================
- Hits 14215 8882 -5333
+ Misses 12801 8339 -4462
- Partials 643 734 +91
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [880 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.99%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 49.05% -2.00%
+ Complexity 2667 2619 -48
============================================
Files 721 720 -1
Lines 17761 17824 +63
Branches 1708 1687 -21
============================================
- Hits 9067 8744 -323
- Misses 7962 8355 +393
+ Partials 732 725 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [72 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618430192
> need comment!
@geektcp What do you mean?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#discussion_r414272306
##########
File path: docs/en/setup/backend/backend-fetcher.md
##########
@@ -0,0 +1,13 @@
+# Open Fetcher
+Fetcher is a concept in SkyWalking backend. It uses pulling mode rather than [receiver](backend-receivers.md), which
+read the data from the target systems. This mode is typically in some metrics SDKs, such as Prometheus.
+
+## Prometheus Fetcher
+```yaml
+prometheus-fetcher:
+ selector: ${SW_PROMETHEUS_FETCHER:default}
Review comment:
What do you mean? I think in any case, we need our own fecthcer, otherwise, who will fetch the data?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 159 -1117
Lines 27692 3835 -23857
Branches 3004 452 -2552
============================================
- Hits 14211 0 -14211
+ Misses 12838 3835 -9003
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1239 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 149 -1127
Lines 27692 3710 -23982
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3710 -9128
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1244 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...7374c76](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `17.94%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.05% 33.10% -17.95%
+ Complexity 2667 1722 -945
=============================================
Files 721 701 -20
Lines 17761 17355 -406
Branches 1708 1651 -57
=============================================
- Hits 9067 5746 -3321
- Misses 7962 11179 +3217
+ Partials 732 430 -302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [252 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 147 -1128
Lines 27659 3659 -24000
Branches 3003 440 -2563
============================================
- Hits 14215 0 -14215
+ Misses 12801 3659 -9142
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [1245 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618259757
@mrproliu @JaredTan95 @arugal Does any of you what to add a meter/metrics toolkit package for metrics collection? Also take part in this PR about the backend feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 148 -1128
Lines 27692 3706 -23986
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3706 -9132
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618890931
1. Make slow trace query available in the sampled record. Logically, they are the same thing. The UI doesn't need to concern about the trace as a special case.
1. Endpoint dependency will be removed from the dashboard. Because no query available for it. We will provide a new page for that in 8.1, according to @Fine0830
1. Comparison page will be removed due to dashboard is powerful enough to replace it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `17.94%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.05% 33.10% -17.95%
+ Complexity 2667 1722 -945
=============================================
Files 721 701 -20
Lines 17761 17355 -406
Branches 1708 1651 -57
=============================================
- Hits 9067 5746 -3321
- Misses 7962 11179 +3217
+ Partials 732 430 -302
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [252 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 158 -1117
Lines 27659 3888 -23771
Branches 3003 466 -2537
============================================
- Hits 14215 0 -14215
+ Misses 12801 3888 -8913
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/776d508018daf342931df9111d1fd19836e683a8&el=desc) will **decrease** coverage by `50.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 50.93% 0.00% -50.94%
============================================
Files 722 148 -574
Lines 17800 3683 -14117
Branches 1709 437 -1272
============================================
- Hits 9066 0 -9066
+ Misses 7999 3683 -4316
+ Partials 735 0 -735
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [685 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [776d508...a9ca06b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 148 -1128
Lines 27692 3706 -23986
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3706 -9132
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 160 -1115
Lines 27659 3900 -23759
Branches 3003 466 -2537
============================================
- Hits 14215 0 -14215
+ Misses 12801 3900 -8901
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io commented on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 160 -562
Lines 17800 3900 -13900
Branches 1709 466 -1243
============================================
- Hits 9093 0 -9093
+ Misses 7980 3900 -4080
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...he/skywalking/apm/agent/core/context/tag/Tags.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90YWcvVGFncy5qYXZh) | `0.00% <0.00%> (-85.72%)` | `0.00 <0.00> (-1.00)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 51.12% -0.27%
- Complexity 2668 2704 +36
============================================
Files 1275 728 -547
Lines 27659 18013 -9646
Branches 3003 1723 -1280
============================================
- Hits 14215 9209 -5006
+ Misses 12801 8061 -4740
- Partials 643 743 +100
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [877 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 165 -1111
Lines 27692 3956 -23736
Branches 3004 467 -2537
============================================
- Hits 14211 0 -14211
+ Misses 12838 3956 -8882
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1236 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...65feb8f](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.92%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.47% -12.93%
+ Complexity 2668 2128 -540
=============================================
Files 1275 706 -569
Lines 27659 17381 -10278
Branches 3003 1657 -1346
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10123 -2678
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [935 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.63%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.41% -0.64%
+ Complexity 2667 2653 -14
============================================
Files 721 721
Lines 17761 17839 +78
Branches 1708 1688 -20
============================================
- Hits 9067 8994 -73
- Misses 7962 8106 +144
- Partials 732 739 +7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [64 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.92%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.47% -12.93%
+ Complexity 2668 2128 -540
=============================================
Files 1275 706 -569
Lines 27659 17381 -10278
Branches 3003 1657 -1346
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10123 -2678
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [935 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.92%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.47% -12.93%
+ Complexity 2668 2128 -540
=============================================
Files 1275 706 -569
Lines 27659 17381 -10278
Branches 3003 1657 -1346
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10123 -2678
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [935 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.48%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.56% -0.49%
+ Complexity 2667 2660 -7
============================================
Files 721 721
Lines 17761 17839 +78
Branches 1708 1688 -20
============================================
- Hits 9067 9020 -47
- Misses 7962 8076 +114
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 151 -1125
Lines 27692 3720 -23972
Branches 3004 444 -2560
============================================
- Hits 14211 0 -14211
+ Misses 12838 3720 -9118
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1245 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...65feb8f](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 152 -570
Lines 17800 3731 -14069
Branches 1709 444 -1265
============================================
- Hits 9093 0 -9093
+ Misses 7980 3731 -4249
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [685 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.82%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.56% -12.83%
+ Complexity 2668 2128 -540
=============================================
Files 1275 702 -573
Lines 27659 17338 -10321
Branches 3003 1652 -1351
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10080 -2721
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [938 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `6.78%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 44.61% -6.79%
+ Complexity 2668 2464 -204
============================================
Files 1275 727 -548
Lines 27659 17919 -9740
Branches 3003 1721 -1282
============================================
- Hits 14215 7994 -6221
+ Misses 12801 9260 -3541
- Partials 643 665 +22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [896 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.99%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 49.05% -2.00%
+ Complexity 2667 2619 -48
============================================
Files 721 720 -1
Lines 17761 17824 +63
Branches 1708 1687 -21
============================================
- Hits 9067 8744 -323
- Misses 7962 8355 +393
+ Partials 732 725 -7
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [72 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `24.39%`.
> The diff coverage is `25.98%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 27.00% -24.40%
+ Complexity 2668 1488 -1180
=============================================
Files 1275 709 -566
Lines 27659 17470 -10189
Branches 3003 1672 -1331
=============================================
- Hits 14215 4717 -9498
+ Misses 12801 12421 -380
+ Partials 643 332 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| ... and [986 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.82%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.56% -12.83%
+ Complexity 2668 2128 -540
=============================================
Files 1275 702 -573
Lines 27659 17338 -10321
Branches 3003 1652 -1351
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10080 -2721
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [938 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `24.39%`.
> The diff coverage is `25.98%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 27.00% -24.40%
+ Complexity 2668 1488 -1180
=============================================
Files 1275 709 -566
Lines 27659 17470 -10189
Branches 3003 1672 -1331
=============================================
- Hits 14215 4717 -9498
+ Misses 12801 12421 -380
+ Partials 643 332 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| ... and [986 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 152 -570
Lines 17800 3731 -14069
Branches 1709 444 -1265
============================================
- Hits 9093 0 -9093
+ Misses 7980 3731 -4249
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [685 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#discussion_r414271755
##########
File path: docs/en/setup/backend/backend-fetcher.md
##########
@@ -0,0 +1,13 @@
+# Open Fetcher
+Fetcher is a concept in SkyWalking backend. It uses pulling mode rather than [receiver](backend-receivers.md), which
+read the data from the target systems. This mode is typically in some metrics SDKs, such as Prometheus.
+
+## Prometheus Fetcher
+```yaml
+prometheus-fetcher:
+ selector: ${SW_PROMETHEUS_FETCHER:default}
Review comment:
BTW, I'm a little confused about the "selectors", which scenariodos do we need to provide our own Prometheus fetcher provider? 🤔️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 158 -1117
Lines 27659 3888 -23771
Branches 3003 466 -2537
============================================
- Hits 14215 0 -14215
+ Misses 12801 3888 -8913
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#discussion_r413732399
##########
File path: oap-server/server-fetcher-plugin/prometheus-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/fetcher/prometheus/provider/PrometheusFetcherProvider.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.fetcher.prometheus.provider;
+
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.analysis.TimeBucket;
+import org.apache.skywalking.oap.server.core.analysis.meter.MeterEntity;
+import org.apache.skywalking.oap.server.core.analysis.meter.MeterSystem;
+import org.apache.skywalking.oap.server.core.analysis.meter.ScopeType;
+import org.apache.skywalking.oap.server.core.analysis.meter.function.AcceptableValue;
+import org.apache.skywalking.oap.server.fetcher.prometheus.module.PrometheusFetcherModule;
+import org.apache.skywalking.oap.server.library.module.ModuleConfig;
+import org.apache.skywalking.oap.server.library.module.ModuleDefine;
+import org.apache.skywalking.oap.server.library.module.ModuleProvider;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import org.apache.skywalking.oap.server.library.module.ServiceNotProvidedException;
+
+public class PrometheusFetcherProvider extends ModuleProvider {
+ private final PrometheusFetcherConfig config;
+
+ public PrometheusFetcherProvider() {
+ config = new PrometheusFetcherConfig();
+ }
+
+ @Override
+ public String name() {
+ return "default";
+ }
+
+ @Override
+ public Class<? extends ModuleDefine> module() {
+ return PrometheusFetcherModule.class;
+ }
+
+ @Override
+ public ModuleConfig createConfigBeanIfAbsent() {
+ return config;
+ }
+
+ @Override
+ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
+ final MeterSystem meterSystem = MeterSystem.meterSystem(getManager());
+ meterSystem.create("test_long_metrics", "avg", ScopeType.SERVICE, Long.class);
+ }
+
+ @Override
+ public void start() throws ServiceNotProvidedException, ModuleStartException {
+
+ }
+
+ @Override
+ public void notifyAfterCompleted() throws ServiceNotProvidedException, ModuleStartException {
+ final MeterSystem service = getManager().find(CoreModule.NAME).provider().getService(MeterSystem.class);
+ Executors.newSingleThreadScheduledExecutor().scheduleAtFixedRate(new Runnable() {
+ @Override
+ public void run() {
+ final AcceptableValue<Long> value = service.buildMetrics("test_long_metrics", Long.class);
+ value.accept(MeterEntity.newService("abc"), 5L);
+ value.setTimeBucket(TimeBucket.getMinuteTimeBucket(System.currentTimeMillis()));
+ service.doStreamingCalculation(value);
+ }
+ }, 2, 2, TimeUnit.SECONDS);
+ }
Review comment:
For demo, yes. Prometheus doesn't have client, OAP fetchs data from target instrumented applications.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 152 -1123
Lines 27659 3731 -23928
Branches 3003 444 -2559
============================================
- Hits 14215 0 -14215
+ Misses 12801 3731 -9070
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1242 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 158 -564
Lines 17800 3830 -13970
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3830 -4150
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [679 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 149 -1127
Lines 27692 3710 -23982
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3710 -9128
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 152 -570
Lines 17800 3731 -14069
Branches 1709 444 -1265
============================================
- Hits 9093 0 -9093
+ Misses 7980 3731 -4249
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [685 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 152 -570
Lines 17800 3731 -14069
Branches 1709 444 -1265
============================================
- Hits 9093 0 -9093
+ Misses 7980 3731 -4249
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [685 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `8.12%`.
> The diff coverage is `63.02%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 43.26% -8.13%
+ Complexity 2668 2128 -540
============================================
Files 1275 1279 +4
Lines 27659 27818 +159
Branches 3003 3022 +19
============================================
- Hits 14215 12036 -2179
- Misses 12801 15131 +2330
- Partials 643 651 +8
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.24% <62.24%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `72.91% <72.91%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [159 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] dmsolr commented on a change in pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
dmsolr commented on a change in pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#discussion_r413720891
##########
File path: oap-server/server-fetcher-plugin/prometheus-fetcher-plugin/src/main/java/org/apache/skywalking/oap/server/fetcher/prometheus/provider/PrometheusFetcherProvider.java
##########
@@ -0,0 +1,87 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.fetcher.prometheus.provider;
+
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import org.apache.skywalking.oap.server.core.CoreModule;
+import org.apache.skywalking.oap.server.core.analysis.TimeBucket;
+import org.apache.skywalking.oap.server.core.analysis.meter.MeterEntity;
+import org.apache.skywalking.oap.server.core.analysis.meter.MeterSystem;
+import org.apache.skywalking.oap.server.core.analysis.meter.ScopeType;
+import org.apache.skywalking.oap.server.core.analysis.meter.function.AcceptableValue;
+import org.apache.skywalking.oap.server.fetcher.prometheus.module.PrometheusFetcherModule;
+import org.apache.skywalking.oap.server.library.module.ModuleConfig;
+import org.apache.skywalking.oap.server.library.module.ModuleDefine;
+import org.apache.skywalking.oap.server.library.module.ModuleProvider;
+import org.apache.skywalking.oap.server.library.module.ModuleStartException;
+import org.apache.skywalking.oap.server.library.module.ServiceNotProvidedException;
+
+public class PrometheusFetcherProvider extends ModuleProvider {
+ private final PrometheusFetcherConfig config;
+
+ public PrometheusFetcherProvider() {
+ config = new PrometheusFetcherConfig();
+ }
+
+ @Override
+ public String name() {
+ return "default";
+ }
+
+ @Override
+ public Class<? extends ModuleDefine> module() {
+ return PrometheusFetcherModule.class;
+ }
+
+ @Override
+ public ModuleConfig createConfigBeanIfAbsent() {
+ return config;
+ }
+
+ @Override
+ public void prepare() throws ServiceNotProvidedException, ModuleStartException {
+ final MeterSystem meterSystem = MeterSystem.meterSystem(getManager());
+ meterSystem.create("test_long_metrics", "avg", ScopeType.SERVICE, Long.class);
+ }
+
+ @Override
+ public void start() throws ServiceNotProvidedException, ModuleStartException {
+
+ }
+
+ @Override
+ public void notifyAfterCompleted() throws ServiceNotProvidedException, ModuleStartException {
+ final MeterSystem service = getManager().find(CoreModule.NAME).provider().getService(MeterSystem.class);
+ Executors.newSingleThreadScheduledExecutor().scheduleAtFixedRate(new Runnable() {
+ @Override
+ public void run() {
+ final AcceptableValue<Long> value = service.buildMetrics("test_long_metrics", Long.class);
+ value.accept(MeterEntity.newService("abc"), 5L);
+ value.setTimeBucket(TimeBucket.getMinuteTimeBucket(System.currentTimeMillis()));
+ service.doStreamingCalculation(value);
+ }
+ }, 2, 2, TimeUnit.SECONDS);
+ }
Review comment:
Is FetchProvider a demonstration?
The Metrics are reported by Prometheus client or SkyWalking Agent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 149 -1127
Lines 27692 3710 -23982
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3710 -9128
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `19.42%`.
> The diff coverage is `25.98%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 31.96% -19.43%
+ Complexity 2668 1724 -944
=============================================
Files 1275 711 -564
Lines 27659 17504 -10155
Branches 3003 1687 -1316
=============================================
- Hits 14215 5596 -8619
+ Misses 12801 11498 -1303
+ Partials 643 410 -233
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| ... and [967 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] JaredTan95 commented on a change in pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
JaredTan95 commented on a change in pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#discussion_r414271755
##########
File path: docs/en/setup/backend/backend-fetcher.md
##########
@@ -0,0 +1,13 @@
+# Open Fetcher
+Fetcher is a concept in SkyWalking backend. It uses pulling mode rather than [receiver](backend-receivers.md), which
+read the data from the target systems. This mode is typically in some metrics SDKs, such as Prometheus.
+
+## Prometheus Fetcher
+```yaml
+prometheus-fetcher:
+ selector: ${SW_PROMETHEUS_FETCHER:default}
Review comment:
BTW, I'm a little confused about the "selector", which scenariodos do we need to provide our own Prometheus fetcher provider? 🤔️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.52% -0.53%
+ Complexity 2667 2659 -8
============================================
Files 721 721
Lines 17761 17839 +78
Branches 1708 1688 -20
============================================
- Hits 9067 9013 -54
- Misses 7962 8084 +122
- Partials 732 742 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [61 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.06%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.33% -1.07%
- Complexity 2668 2672 +4
============================================
Files 1275 729 -546
Lines 27659 17961 -9698
Branches 3003 1722 -1281
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8188 -4613
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [874 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 158 -1118
Lines 27692 3835 -23857
Branches 3004 452 -2552
============================================
- Hits 14211 0 -14211
+ Misses 12838 3835 -9003
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1242 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `23.28%`.
> The diff coverage is `1.33%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.31% 28.03% -23.29%
=============================================
Files 1276 1218 -58
Lines 27692 26738 -954
Branches 3004 3320 +316
=============================================
- Hits 14211 7496 -6715
- Misses 12838 18565 +5727
- Partials 643 677 +34
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-80.92%)` | `0.00 <0.00> (-8.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-4.00)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-88.53%)` | `0.00 <0.00> (-9.00)` | |
| [.../oap/server/core/storage/model/ModelInstaller.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9tb2RlbC9Nb2RlbEluc3RhbGxlci5qYXZh) | `0.00% <0.00%> (-60.00%)` | `0.00 <0.00> (-6.00)` | |
| [...her/prometheus/module/PrometheusFetcherModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9tb2R1bGUvUHJvbWV0aGV1c0ZldGNoZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [609 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 152 -570
Lines 17800 3731 -14069
Branches 1709 444 -1265
============================================
- Hits 9093 0 -9093
+ Misses 7980 3731 -4249
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [685 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 152 -1124
Lines 27692 3764 -23928
Branches 3004 450 -2554
============================================
- Hits 14211 0 -14211
+ Misses 12838 3764 -9074
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `17.30%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 34.09% -17.31%
+ Complexity 2668 1835 -833
=============================================
Files 1275 727 -548
Lines 27659 17919 -9740
Branches 3003 1721 -1282
=============================================
- Hits 14215 6109 -8106
+ Misses 12801 11380 -1421
+ Partials 643 430 -213
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [949 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `6.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 45.22% -6.18%
+ Complexity 2668 2500 -168
============================================
Files 1275 727 -548
Lines 27659 17919 -9740
Branches 3003 1721 -1282
============================================
- Hits 14215 8103 -6112
+ Misses 12801 9151 -3650
- Partials 643 665 +22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [890 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.52%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.52% -0.53%
+ Complexity 2667 2659 -8
============================================
Files 721 721
Lines 17761 17839 +78
Branches 1708 1688 -20
============================================
- Hits 9067 9013 -54
- Misses 7962 8084 +122
- Partials 732 742 +10
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [61 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `17.27%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 34.12% -17.28%
+ Complexity 2668 1498 -1170
=============================================
Files 1275 565 -710
Lines 27659 14059 -13600
Branches 3003 1271 -1732
=============================================
- Hits 14215 4797 -9418
+ Misses 12801 8923 -3878
+ Partials 643 339 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [1004 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `0.65%`.
> The diff coverage is `63.55%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.05% 50.39% -0.66%
+ Complexity 2667 2660 -7
============================================
Files 721 726 +5
Lines 17761 17899 +138
Branches 1708 1695 -13
============================================
- Hits 9067 9020 -47
- Misses 7962 8136 +174
- Partials 732 743 +11
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...8b8900b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 155 -1121
Lines 27692 3785 -23907
Branches 3004 451 -2553
============================================
- Hits 14211 0 -14211
+ Misses 12838 3785 -9053
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.82%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.56% -12.83%
+ Complexity 2668 2128 -540
=============================================
Files 1275 702 -573
Lines 27659 17338 -10321
Branches 3003 1652 -1351
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10080 -2721
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [938 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/776d508018daf342931df9111d1fd19836e683a8&el=desc) will **decrease** coverage by `22.90%`.
> The diff coverage is `1.28%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 50.93% 28.02% -22.91%
=============================================
Files 722 1218 +496
Lines 17800 26749 +8949
Branches 1709 3322 +1613
=============================================
- Hits 9066 7496 -1570
- Misses 7999 18576 +10577
+ Partials 735 677 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `0.00% <0.00%> (-80.92%)` | `0.00 <0.00> (-8.00)` | |
| [...ing/oap/server/core/analysis/StreamDefinition.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvU3RyZWFtRGVmaW5pdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `0.00% <0.00%> (-48.65%)` | `0.00 <0.00> (-2.00)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `0.00 <0.00> (-4.00)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `0.00% <0.00%> (-88.53%)` | `0.00 <0.00> (-9.00)` | |
| [...her/prometheus/module/PrometheusFetcherModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9tb2R1bGUvUHJvbWV0aGV1c0ZldGNoZXJNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| ... and [1218 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [776d508...a9ca06b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 159 -1117
Lines 27692 3835 -23857
Branches 3004 452 -2552
============================================
- Hits 14211 0 -14211
+ Misses 12838 3835 -9003
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1239 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/776d508018daf342931df9111d1fd19836e683a8&el=desc) will **decrease** coverage by `0.30%`.
> The diff coverage is `25.67%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 50.93% 50.62% -0.31%
- Complexity 2670 2687 +17
============================================
Files 722 730 +8
Lines 17800 18005 +205
Branches 1709 1723 +14
============================================
+ Hits 9066 9115 +49
- Misses 7999 8155 +156
Partials 735 735
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...er/core/analysis/manual/segment/SegmentRecord.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3NlZ21lbnQvU2VnbWVudFJlY29yZC5qYXZh) | `52.38% <80.00%> (+3.73%)` | `2.00 <0.00> (ø)` | |
| ... and [19 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [776d508...a9ca06b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `24.39%`.
> The diff coverage is `25.98%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 27.00% -24.40%
+ Complexity 2668 1488 -1180
=============================================
Files 1275 709 -566
Lines 27659 17470 -10189
Branches 3003 1672 -1331
=============================================
- Hits 14215 4717 -9498
+ Misses 12801 12421 -380
+ Partials 643 332 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| ... and [986 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `1.17%`.
> The diff coverage is `24.42%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 50.22% -1.18%
- Complexity 2668 2672 +4
============================================
Files 1275 730 -545
Lines 27659 18000 -9659
Branches 3003 1723 -1280
============================================
- Hits 14215 9040 -5175
+ Misses 12801 8227 -4574
- Partials 643 733 +90
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...king/oap/server/core/analysis/meter/ScopeType.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvU2NvcGVUeXBlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...n/elasticsearch7/query/AggregationQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9BZ2dyZWdhdGlvblF1ZXJ5RXM3REFPLmphdmE=) | `5.55% <0.00%> (-2.14%)` | `1.00 <0.00> (ø)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `23.71% <23.71%> (ø)` | `5.00 <5.00> (?)` | |
| [...prometheus/provider/PrometheusFetcherProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4vcHJvbWV0aGV1cy1mZXRjaGVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2ZldGNoZXIvcHJvbWV0aGV1cy9wcm92aWRlci9Qcm9tZXRoZXVzRmV0Y2hlclByb3ZpZGVyLmphdmE=) | `62.50% <62.50%> (ø)` | `8.00 <8.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| ... and [875 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 151 -1125
Lines 27692 3720 -23972
Branches 3004 444 -2560
============================================
- Hits 14211 0 -14211
+ Misses 12838 3720 -9118
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1245 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...65feb8f](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 158 -1117
Lines 27659 3888 -23771
Branches 3003 466 -2537
============================================
- Hits 14215 0 -14215
+ Misses 12801 3888 -8913
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `51.39%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.39% 0.00% -51.40%
============================================
Files 1275 160 -1115
Lines 27659 3900 -23759
Branches 3003 466 -2537
============================================
- Hits 14215 0 -14215
+ Misses 12801 3900 -8901
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1237 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.92%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.47% -12.93%
+ Complexity 2668 2128 -540
=============================================
Files 1275 706 -569
Lines 27659 17381 -10278
Branches 3003 1657 -1346
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10123 -2678
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [935 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 148 -1128
Lines 27692 3706 -23986
Branches 3004 443 -2561
============================================
- Hits 14211 0 -14211
+ Misses 12838 3706 -9132
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on pull request #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/15f1e048e9d83b77f72355b26e47a320e64fab9a&el=desc) will **decrease** coverage by `12.92%`.
> The diff coverage is `67.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
=============================================
- Coverage 51.39% 38.47% -12.93%
+ Complexity 2668 2128 -540
=============================================
Files 1275 706 -569
Lines 27659 17381 -10278
Branches 3003 1657 -1346
=============================================
- Hits 14215 6687 -7528
+ Misses 12801 10123 -2678
+ Partials 643 571 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...p/server/core/analysis/metrics/LongAvgMetrics.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9Mb25nQXZnTWV0cmljcy5qYXZh) | `100.00% <ø> (ø)` | `4.00 <0.00> (ø)` | |
| [...gin/elasticsearch/query/AggregationQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvQWdncmVnYXRpb25RdWVyeUVzREFPLmphdmE=) | `0.00% <0.00%> (-7.70%)` | `0.00 <0.00> (-1.00)` | |
| [...rver/tool/profile/core/MockCoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9Nb2NrQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `8.47% <0.00%> (-0.46%)` | `2.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/meter/MeterEntity.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJFbnRpdHkuamF2YQ==) | `53.33% <53.33%> (ø)` | `3.00 <3.00> (?)` | |
| [...ng/oap/server/core/analysis/meter/MeterSystem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvTWV0ZXJTeXN0ZW0uamF2YQ==) | `62.88% <62.88%> (ø)` | `12.00 <12.00> (?)` | |
| [...g/oap/server/core/analysis/meter/function/Avg.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0ZXIvZnVuY3Rpb24vQXZnLmphdmE=) | `74.46% <74.46%> (ø)` | `7.00 <7.00> (?)` | |
| [...r/core/analysis/worker/MetricsStreamProcessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL01ldHJpY3NTdHJlYW1Qcm9jZXNzb3IuamF2YQ==) | `88.88% <81.81%> (+0.36%)` | `10.00 <4.00> (+1.00)` | |
| [...apache/skywalking/oal/rt/parser/MetricsHolder.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9vYWwtcnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FsL3J0L3BhcnNlci9NZXRyaWNzSG9sZGVyLmphdmE=) | `82.35% <100.00%> (ø)` | `5.00 <1.00> (ø)` | |
| [.../apache/skywalking/oap/server/core/CoreModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZS5qYXZh) | `100.00% <100.00%> (ø)` | `8.00 <0.00> (ø)` | |
| [...skywalking/oap/server/core/CoreModuleProvider.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvQ29yZU1vZHVsZVByb3ZpZGVyLmphdmE=) | `76.86% <100.00%> (-4.06%)` | `8.00 <1.00> (ø)` | |
| ... and [935 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [15f1e04...2ba582b](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/991d08337800b28dfe3c03eb8c166fe137c05e35&el=desc) will **decrease** coverage by `51.08%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.08% 0.00% -51.09%
============================================
Files 722 159 -563
Lines 17800 3835 -13965
Branches 1709 452 -1257
============================================
- Hits 9093 0 -9093
+ Misses 7980 3835 -4145
+ Partials 727 0 -727
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [678 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [991d083...552211d](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov-io edited a comment on issue #4694: Provide Meter(metrics) system
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #4694:
URL: https://github.com/apache/skywalking/pull/4694#issuecomment-618171974
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=h1) Report
> Merging [#4694](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/cf7482a79c0d36cab07c3bb38c0b222a3510f133&el=desc) will **decrease** coverage by `51.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4694 +/- ##
============================================
- Coverage 51.31% 0.00% -51.32%
============================================
Files 1276 155 -1121
Lines 27692 3785 -23907
Branches 3004 451 -2553
============================================
- Hits 14211 0 -14211
+ Misses 12838 3785 -9053
+ Partials 643 0 -643
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...pache/skywalking/apm/agent/core/base64/Base64.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvYmFzZTY0L0Jhc2U2NC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [1243 more](https://codecov.io/gh/apache/skywalking/pull/4694/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=footer). Last update [cf7482a...e03deb0](https://codecov.io/gh/apache/skywalking/pull/4694?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org