You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2021/10/11 08:45:32 UTC

[GitHub] [buildstream] gtristan opened a new pull request #1526: WIP: Remove bst-artifact-server

gtristan opened a new pull request #1526:
URL: https://github.com/apache/buildstream/pull/1526


   This fixes #1468


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] gtristan commented on pull request #1526: WIP: Remove bst-artifact-server

Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1526:
URL: https://github.com/apache/buildstream/pull/1526#issuecomment-939953733


   > At the very least for testing we need to keep the server around. It makes sense to remove it from the list of entry points to install to make it clear that we recommend better servers for production use. However, for testing, this trivial implementation is sensible, in my opinion.
   
   Perhaps we should move it to the tests directory, or better yet, to `buildstream.testing`...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] juergbi commented on pull request #1526: WIP: Remove bst-artifact-server

Posted by GitBox <gi...@apache.org>.
juergbi commented on pull request #1526:
URL: https://github.com/apache/buildstream/pull/1526#issuecomment-939846452


   At the very least for testing we need to keep the server around. It makes sense to remove it from the list of entry points to install to make it clear that we recommend better servers for production use. However, for testing, this trivial implementation is sensible, in my opinion.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] gtristan merged pull request #1526: Remove bst-artifact-server

Posted by GitBox <gi...@apache.org>.
gtristan merged pull request #1526:
URL: https://github.com/apache/buildstream/pull/1526


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [buildstream] gtristan commented on pull request #1526: WIP: Remove bst-artifact-server

Posted by GitBox <gi...@apache.org>.
gtristan commented on pull request #1526:
URL: https://github.com/apache/buildstream/pull/1526#issuecomment-940665616


   > [...]
   > Perhaps we should move it to the tests directory, or better yet, to `buildstream.testing`...
   
   Scratch that, I think it makes better sense to keep it all together with it's family in the `_cas/` subdir.
   
   I'll finish this up by amending documentation and explaining how to use `bb-storage` and `bb-remote-asset`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org