You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Siying Dong (JIRA)" <ji...@apache.org> on 2011/06/23 09:27:47 UTC
[jira] [Created] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Cli: Print Hadoop's CPU milliseconds
------------------------------------
Key: HIVE-2236
URL: https://issues.apache.org/jira/browse/HIVE-2236
Project: Hive
Issue Type: New Feature
Components: CLI
Reporter: Siying Dong
Priority: Minor
CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Attachment: HIVE-2236.2.patch
remove the MapRedStat list from DriverContext and add more counters.
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Carl Steinbach (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Carl Steinbach updated HIVE-2236:
---------------------------------
Fix Version/s: 0.8.0
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch, HIVE-2236.4.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Status: Patch Available (was: Open)
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070638#comment-13070638 ]
He Yongqiang commented on HIVE-2236:
------------------------------------
+1, will commit after tests pass
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong reassigned HIVE-2236:
---------------------------------
Assignee: Siying Dong
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Status: Patch Available (was: Open)
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Attachment: HIVE-2236.4.patch
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch, HIVE-2236.4.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070944#comment-13070944 ]
Hudson commented on HIVE-2236:
------------------------------
Integrated in Hive-trunk-h0.21 #848 (See [https://builds.apache.org/job/Hive-trunk-h0.21/848/])
HIVE-2236: Print Hadoop's CPU milliseconds in Cli. (Siying Dong via He Yongqiang)
heyongqiang : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1150945
Files :
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java
* /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch, HIVE-2236.4.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Status: Open (was: Patch Available)
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13070640#comment-13070640 ]
He Yongqiang commented on HIVE-2236:
------------------------------------
siying, can you rebase this patch? thanks!
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Attachment: HIVE-2236.3.patch
fix a bug
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054513#comment-13054513 ]
jiraposter@reviews.apache.org commented on HIVE-2236:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/948/#review904
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1947>
why do you need to pull this var out of the code block?
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1948>
can you not store the MapRedStatsList in DriverContext?
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1949>
format the code here
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/948/#comment1959>
how do you know the hadoop support this counter
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/948/#comment1960>
are u going to print this info if this job failed?
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/948/#comment1958>
remove 'ms'
- Yongqiang
On 2011-06-23 07:41:33, Siying Dong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/948/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-23 07:41:33)
bq.
bq.
bq. Review request for hive, Yongqiang He, Ning Zhang, and namit jain.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In hive CLI, print out CPU msec from Hadoop MapReduce coutners.
bq.
bq.
bq. This addresses bug HIVE-2236.
bq. https://issues.apache.org/jira/browse/HIVE-2236
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java PRE-CREATION
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1138748
bq.
bq. Diff: https://reviews.apache.org/r/948/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. run the updated codes against real clusters and make sure it printing is correct.
bq.
bq.
bq. Thanks,
bq.
bq. Siying
bq.
bq.
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2236:
-------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
committed, thanks Siying!
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch, HIVE-2236.4.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
He Yongqiang updated HIVE-2236:
-------------------------------
Status: Open (was: Patch Available)
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Attachment: HIVE-2236.1.patch
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13068169#comment-13068169 ]
jiraposter@reviews.apache.org commented on HIVE-2236:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/948/
-----------------------------------------------------------
(Updated 2011-07-20 06:27:19.820431)
Review request for hive, Yongqiang He, Ning Zhang, and namit jain.
Changes
-------
remove MapRedStats from DriverContext and add more counters to it.
Summary
-------
In hive CLI, print out CPU msec from Hadoop MapReduce coutners.
This addresses bug HIVE-2236.
https://issues.apache.org/jira/browse/HIVE-2236
Diffs (updated)
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1148623
Diff: https://reviews.apache.org/r/948/diff
Testing
-------
run the updated codes against real clusters and make sure it printing is correct.
Thanks,
Siying
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "Siying Dong (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siying Dong updated HIVE-2236:
------------------------------
Status: Patch Available (was: Open)
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13053684#comment-13053684 ]
jiraposter@reviews.apache.org commented on HIVE-2236:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/948/
-----------------------------------------------------------
Review request for hive, Yongqiang He, Ning Zhang, and namit jain.
Summary
-------
In hive CLI, print out CPU msec from Hadoop MapReduce coutners.
This addresses bug HIVE-2236.
https://issues.apache.org/jira/browse/HIVE-2236
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1138748
trunk/ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1138748
trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1138748
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1138748
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1138748
trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1138748
Diff: https://reviews.apache.org/r/948/diff
Testing
-------
run the updated codes against real clusters and make sure it printing is correct.
Thanks,
Siying
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054583#comment-13054583 ]
jiraposter@reviews.apache.org commented on HIVE-2236:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/948/#review909
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1962>
Because I use this in finally block.
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java
<https://reviews.apache.org/r/948/#comment1963>
What's the concern?
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/948/#comment1964>
We might not. If it doesn't support it will return null. That's why I have a null logic next to ignore null results and don't record anything.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java
<https://reviews.apache.org/r/948/#comment1965>
Yes.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java
<https://reviews.apache.org/r/948/#comment1966>
Why?
- Siying
On 2011-06-23 07:41:33, Siying Dong wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/948/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-23 07:41:33)
bq.
bq.
bq. Review request for hive, Yongqiang He, Ning Zhang, and namit jain.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. In hive CLI, print out CPU msec from Hadoop MapReduce coutners.
bq.
bq.
bq. This addresses bug HIVE-2236.
bq. https://issues.apache.org/jira/browse/HIVE-2236
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/DriverContext.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java PRE-CREATION
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1138748
bq. trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1138748
bq.
bq. Diff: https://reviews.apache.org/r/948/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. run the updated codes against real clusters and make sure it printing is correct.
bq.
bq.
bq. Thanks,
bq.
bq. Siying
bq.
bq.
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HIVE-2236) Cli: Print Hadoop's CPU milliseconds
Posted by "jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HIVE-2236?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13069094#comment-13069094 ]
jiraposter@reviews.apache.org commented on HIVE-2236:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/948/
-----------------------------------------------------------
(Updated 2011-07-21 17:30:55.228025)
Review request for hive, Yongqiang He, Ning Zhang, and namit jain.
Changes
-------
fix a bug
Summary
-------
In hive CLI, print out CPU msec from Hadoop MapReduce coutners.
This addresses bug HIVE-2236.
https://issues.apache.org/jira/browse/HIVE-2236
Diffs (updated)
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/Driver.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/MapRedStats.java PRE-CREATION
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExecDriver.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1148623
trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1148623
Diff: https://reviews.apache.org/r/948/diff
Testing
-------
run the updated codes against real clusters and make sure it printing is correct.
Thanks,
Siying
> Cli: Print Hadoop's CPU milliseconds
> ------------------------------------
>
> Key: HIVE-2236
> URL: https://issues.apache.org/jira/browse/HIVE-2236
> Project: Hive
> Issue Type: New Feature
> Components: CLI
> Reporter: Siying Dong
> Assignee: Siying Dong
> Priority: Minor
> Attachments: HIVE-2236.1.patch, HIVE-2236.2.patch, HIVE-2236.3.patch
>
>
> CPU Milliseonds information is available from Hadoop's framework. Printing it out to Hive CLI when executing a job will help users to know more about their jobs.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira