You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/11/23 08:41:58 UTC
[GitHub] [kafka] chia7712 opened a new pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
chia7712 opened a new pull request #9641:
URL: https://github.com/apache/kafka/pull/9641
as title.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#discussion_r564260770
##########
File path: connect/runtime/src/main/resources/common/message/ConnectAssignment.json
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ // Assignments for each worker are a set of connectors and tasks. These are categorized by
+ // connector ID. A sentinel task ID (CONNECTOR_TASK) is used to indicate the connector itself
+ // (i.e. that the assignment includes responsibility for running the Connector instance in
+ // addition to any tasks it generates).
+ "type": "data",
+ "name": "ConnectAssignment",
+ "validVersions": "0",
+ "fields": [
+ // the error code of this assignment; 0 signals successful assignment
Review comment:
oh, I misunderstood your comment. Will copy that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#issuecomment-767408566
convert this patch to draft as some system tests can't pass on my local
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#discussion_r564255280
##########
File path: connect/runtime/src/main/resources/common/message/ConnectAssignment.json
##########
@@ -0,0 +1,36 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ // Assignments for each worker are a set of connectors and tasks. These are categorized by
+ // connector ID. A sentinel task ID (CONNECTOR_TASK) is used to indicate the connector itself
+ // (i.e. that the assignment includes responsibility for running the Connector instance in
+ // addition to any tasks it generates).
+ "type": "data",
+ "name": "ConnectAssignment",
+ "validVersions": "0",
+ "fields": [
+ // the error code of this assignment; 0 signals successful assignment
Review comment:
Why not add the note to the `about` field of the json?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#issuecomment-766740318
cc @kkonstantine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] chia7712 commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
chia7712 commented on a change in pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#discussion_r564213503
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/ConnectProtocol.java
##########
@@ -43,96 +27,9 @@
* joining the group and distributing assignments, and the format of assignments of connectors and tasks to workers.
*/
public class ConnectProtocol {
- public static final String VERSION_KEY_NAME = "version";
- public static final String URL_KEY_NAME = "url";
- public static final String CONFIG_OFFSET_KEY_NAME = "config-offset";
- public static final String CONNECTOR_KEY_NAME = "connector";
- public static final String LEADER_KEY_NAME = "leader";
- public static final String LEADER_URL_KEY_NAME = "leader-url";
- public static final String ERROR_KEY_NAME = "error";
- public static final String TASKS_KEY_NAME = "tasks";
- public static final String ASSIGNMENT_KEY_NAME = "assignment";
public static final int CONNECTOR_TASK = -1;
-
public static final short CONNECT_PROTOCOL_V0 = 0;
Review comment:
I feel the version is bump only if we add new protocol (see https://github.com/apache/kafka/blob/trunk/connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/WorkerCoordinator.java#L190).
For another, your comment inspires me that the constant field can be moved to ```ConnectProtocolCompatibility``` as it is used by ```ConnectProtocolCompatibility``` only
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dengziming commented on a change in pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
dengziming commented on a change in pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#discussion_r548488090
##########
File path: connect/runtime/src/main/resources/common/message/ConnectAssignment.json
##########
@@ -0,0 +1,35 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+{
+ // Assignments for each worker are a set of connectors and tasks. These are categorized by
+ // connector ID. A sentinel task ID (CONNECTOR_TASK) is used to indicate the connector itself
+ // (i.e. that the assignment includes responsibility for running the Connector instance in
+ // addition to any tasks it generates).
+ "type": "data",
+ "name": "ConnectAssignment",
+ "validVersions": "0",
+ "fields": [
+ { "name": "error", "type": "int16", "versions": "0" },
Review comment:
We can add some annotations here.
##########
File path: connect/runtime/src/main/java/org/apache/kafka/connect/runtime/distributed/ConnectProtocol.java
##########
@@ -43,96 +27,9 @@
* joining the group and distributing assignments, and the format of assignments of connectors and tasks to workers.
*/
public class ConnectProtocol {
- public static final String VERSION_KEY_NAME = "version";
- public static final String URL_KEY_NAME = "url";
- public static final String CONFIG_OFFSET_KEY_NAME = "config-offset";
- public static final String CONNECTOR_KEY_NAME = "connector";
- public static final String LEADER_KEY_NAME = "leader";
- public static final String LEADER_URL_KEY_NAME = "leader-url";
- public static final String ERROR_KEY_NAME = "error";
- public static final String TASKS_KEY_NAME = "tasks";
- public static final String ASSIGNMENT_KEY_NAME = "assignment";
public static final int CONNECTOR_TASK = -1;
-
public static final short CONNECT_PROTOCOL_V0 = 0;
Review comment:
The `CONNECT_PROTOCOL_V0` is only used in `ConnectProtocolCompatibility.fromProtocolVersion()`, I think we shouldn't depend on the version to compute `ConnectProtocolCompatibility` because every time we bump the version we should change the method, maybe we can add a field in the ExtendedWorkerMetadata.json to represent the corresponding `ConnectProtocolCompatibility`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ijuma commented on pull request #9641: MINOR: Convert connect assignment schemas to use generated protocol
Posted by GitBox <gi...@apache.org>.
ijuma commented on pull request #9641:
URL: https://github.com/apache/kafka/pull/9641#issuecomment-766740318
cc @kkonstantine
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org