You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/06/26 07:11:32 UTC

[GitHub] eolivelli edited a comment on issue #1527: Make ExplicitLAC persistent

eolivelli edited a comment on issue #1527: Make ExplicitLAC persistent
URL: https://github.com/apache/bookkeeper/issues/1527#issuecomment-400203615
 
 
   Some thoughts (thinking out loud):
   - I think we should unify ExplicitLAC and PiggyBackLAC, for instance we should update this new field on FileInfo both on setExplicitLAC and on addEntry
   - We should change readLastAddConfirmed so that the reader will use this new value, and there will be no need to call readExplicitLAC, which is very confusing for the user
   - If this setExplicitLAC operation is logged to the journal and we wait for fsync, it can be a good to update writer-side LAC in case of DEFERRED_SYNC
   
   
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services