[GitHub] csantanapr closed pull request #166: query_params should not be required when using filter

[GitBox <gi...@apache.org>]

csantanapr closed pull request #166: query_params should not be required when using filter
URL: https://github.com/apache/incubator-openwhisk-package-cloudant/pull/166
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.travis.yml b/.travis.yml
index 7f977bb..ce79a21 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -12,6 +12,7 @@ env:
     - secure: "c2PoumiBu9Q0ko31/azS8aml2hjv9pPIURxnNfKFWnru0UxXW/F06XAuzyfiBUSXcWgZ+mV2aOj+Fyjr67d1GCtcb8w3lVbaubdlDp+HQQ4iIz0YcTR6FZgLT3iQNVYqZEfmu4/98aeQozmLHbzXHbrw/Dv2PgGTRTrcZuMIb758SI3rFeA87IN4FtotvPXEqQa5w3GGNiFEWOrswKE2bVpeW8IKmdnlX+QCbBBHUoNcHlz93SPBfmbz2IBMV0eWtqw+zAAH6iynIetoxPnBz+mNdyEKRHNGmj3hsJsyN7KPI0ZhVLbxO6qAeaXdaH6Lq/HwFom8eRg2jY5utyeyovvx/EvhuPQHTxQqZu6giaJPkRYVAfr4hLCVjObgpCa1/jq6nYDPTcY74sA2iX1p2UYkjTo46WBr9Fq82BTrVgT2vp8OTvFXh+oiE9Z8Li0NCgSu0Aps8yUwmpZROTc63yjHslYdNVMn+2tVjKRRkO/6gTVdUKz+vlABE2vI/kK1f6Fc7wX/nYdMhgLuLdwKJdWURRGAQchzcBhBlpOFUtXKznJGsk6OUISr2qo0aGpKL2ajj5IEpyAELBLw6YPH2+hO5uoqb5RMMroP7qb6XkLaqia679SErppSwFdzaqAzbgHC/SDlLGP0zIwWhPwBzCNT6YzrEsxO3+nBEX+9x/E="
 
 before_install:
+  - npm conf set strict-ssl false
   - ./tools/travis/setup.sh
 
 install: true
diff --git a/actions/changesWebAction.js b/actions/changesWebAction.js
index f69e286..b72e35d 100644
--- a/actions/changesWebAction.js
+++ b/actions/changesWebAction.js
@@ -47,8 +47,8 @@ function main(params) {
                     return sendError(400, 'The query_params parameter cannot be parsed. Ensure it is valid JSON.');
                 }
             }
-            if (typeof query_params !== 'object') {
-                return sendError(400, 'The query_params parameter is not valid JSON');
+            if (query_params && typeof query_params !== 'object') {
+                return sendError(400, 'The query_params parameter is not a valid JSON Object');
             }
         }
         else if (params.query_params) {
@@ -170,7 +170,7 @@ function main(params) {
                                 }
                             }
                             if (typeof query_params !== 'object') {
-                                reject(sendError(400, 'The query_params parameter is not valid JSON'));
+                                reject(sendError(400, 'The query_params parameter is not a valid JSON Object'));
                             }
                             updatedParams.query_params = query_params;
                         } else {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services