You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Hiram Chirino (JIRA)" <ji...@apache.org> on 2007/07/03 19:42:33 UTC
[jira] Created: (CAMEL-64) Camel DSL should use verbs for it's EIP
actions.
Camel DSL should use verbs for it's EIP actions.
-------------------------------------------------
Key: CAMEL-64
URL: https://issues.apache.org/activemq/browse/CAMEL-64
Project: Apache Camel
Issue Type: Improvement
Components: camel-core
Reporter: Hiram Chirino
Assignee: James Strachan
Fix For: 1.1.0
For example splitter() should be split() and resequencer should be resequence.
Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-64) Camel DSL should use verbs for it's EIP
actions.
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan updated CAMEL-64:
--------------------------------
Fix Version/s: (was: 1.1.0)
1.2.0
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: James Strachan
> Fix For: 1.2.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47365#action_47365 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
Here is the java doc for the splitter method in ProcessorType
/**
* Creates the <a
* href="http://activemq.apache.org/camel/delayer.html">Delayer</a> pattern
* where an expression is used to calculate the time which the message will
* be dispatched on
*
* @return the builder
*/
public ThrottlerType throttler(long maximumRequestCount) {
ThrottlerType answer = new ThrottlerType(maximumRequestCount);
addOutput(answer);
return answer;
}
we could think the throtter method as the ThrotterType creating method,
and it is same with the Spring configuration such as
<camelContext id="camel"
xmlns="http://activemq.apache.org/camel/schema/spring">
<route>
<from uri="seda:a" />
<throttler maximumRequestsPerPeriod="3" timePeriodMillis="30000">
<to uri="mock:result" />
</throttler>
</route>
</camelContext>
In this way we could just think to put a throttler in the middle of router rule, if your are using the GUI to write the rule , you just drop a box which name is throttler in the rule digraph.
If the EPI action is named with noun, it will make the Spring DSL , even the Camel GUI more consistent with the Java DSL.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-64) Camel DSL should use verbs for it's EIP
actions.
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan updated CAMEL-64:
--------------------------------
Assignee: (was: James Strachan)
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Fix For: 1.3.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47724#action_47724 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
Changed the JAXB annotations
AggregatorType
@XmlRootElement(name = "aggregator") -> @XmlRootElement(name = "aggregate")
DelayerType
@XmlRootElement(name = "delay") -> @XmlRootElement(name = "delay")
@XmlElement private Long delay = 0L; -> @XmlElement private Long delayTime = 0L;
RedeliveryPolicyType
@XmlAttribute private Long delay; -> @XmlAttribute private Long redeliveryDelay;
ResequencerType
@XmlRootElement(name = "resequencer") -> @XmlRootElement(name = "resequence")
SplitterType
@XmlRootElement(name = "splitter") -> @XmlRootElement(name = "split")
ThrottlerType
@XmlRootElement(name = "throttler") -> @XmlRootElement(name = "throttle")
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Work started: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on CAMEL-64 started by Willem Jiang.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-64) Camel DSL should use verbs for it's EIP
actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-64:
---------------------------------
Assignee: Willem Jiang
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47344#action_47344 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
Willem I dont understand you @ALL. Could you give an example?
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47741#action_47741 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
We should document on the 2.0 release notes that the DSL have changed for the above types.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47557#action_47557 ]
Hadrian Zbarcea commented on CAMEL-64:
--------------------------------------
Actually, it is possible, but I think we'll be trading different kinds of pains for the users. Since we'll have to removed them at some point, better do it now.
+1 of Claus' proposal to break compatibility.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47370#action_47370 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
Well first of all the javadoc was wrong - I created a ticket CAMEL-1087
I thought the idea of this ticket was to use better wording (verbs) for the DSL
So for instance if you have a route like:
from(x).throttler(10).to(y)
Then when you read it in English it's not correct. It should be:
from(x).throttle(10).to(y)
The same applies for
splitter -> split
aggregator -> aggregate
delayer -> delay
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47709#action_47709 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
@Willem
Should the spring DSL also be changed to use the same verbs as the Java DSL?
For instance: @XmlRootElement(name = "throttler")
Should be:
@XmlRootElement(name = "throttle")
And remeber to change the attribute in RedeliveryPolicyType to also be *redeliveryDelay* so it's aligned with the Java DSL fluent builder syntax:
@XmlAttribute
private Long delay;
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46880#action_46880 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
@Hadrian, I will hold it until we get the conculsion about the DSL :)
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46879#action_46879 ]
Hadrian Zbarcea commented on CAMEL-64:
--------------------------------------
@Willem, could you please not start working on this just yet. I want to have a few discussions about the dsl in the coming weeks that may impact this.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47685#action_47685 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
I would propose the rename the setDelay to redeliveryDelay to use a consitent builder syntax (not having set/get etc.)
In the ExceptionType
setDelay -> redeliveryDelay
Using redeliveryDelay is also concise with the other fluent method such as:
maximumRedeliveryDelay
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47548#action_47548 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
> It is not easy to make the Spring DSL support both throttler and throttle.
No not possible
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-64) Camel DSL should use verbs for it's EIP
actions.
Posted by "James Strachan (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
James Strachan updated CAMEL-64:
--------------------------------
Fix Version/s: (was: 1.2.0)
1.3.0
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: James Strachan
> Fix For: 1.3.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47343#action_47343 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
I think we need to align the Java and Spring DSL so we use the same verbs otherwise it's confusing. So I think we need to clean both Java and Spring DSL if they are not correct.
We better take the API breaks in a big bang with 2.0 than newer.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47704#action_47704 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
@Claus
good suggestion, I will change it in my next commit.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47324#action_47324 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
@Claus
Yes, It is painful and we can't support old spring xsd at the same time. So I suggest we don't tough the Spring DSL.
@ALL
I just went through the ProcessorType and Spring configuration. Now we are using the noun as the processor name, the methods which create the processor types are using the noun for the EIP actions. In these case we can think we just put the processor in the middle of the routing rule, and the processor will take care of the more detail EIP verb action.
So I don't will to use verbs for the EIP actions in Camel DSL.
Any thoughts?
Willem
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47547#action_47547 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
I think we need to break the compability. So the Java DSL should just rename the verbs (no need to mark @deprecated) otherwise the method list when end users hit ctrl+space gets to big.
And hence the spring DSL should also be renamed.
But I also think we need a [HEADS UP] or [DISCUSS] on the dev forum about this breaking, so everyone agrees that we do this
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47542#action_47542 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
Yes, it could be a huge change. I will head to this now.
Do we still need to support throttler in camel 2.0 at the same time?
It is not easy to make the Spring DSL support both throttler and throttle.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-64) Camel DSL should use verbs for it's EIP
actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-64.
-------------------------------
Resolution: Fixed
committed the change and updated the 2.0 release notes.
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CAMEL-64) Camel DSL should use verbs
for it's EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47370#action_47370 ]
davsclaus edited comment on CAMEL-64 at 11/13/08 11:21 PM:
-------------------------------------------------------------
Well first of all the javadoc was wrong - I created a ticket CAMEL-1087
I thought the idea of this ticket was to use better wording (verbs) for the DSL
So for instance if you have a route like:
{code}
from(x).throttler(10).to(y)
{code}
Then when you read it in English it's not correct. It should be:
{code}
from(x).throttle(10).to(y)
{code}
The same applies for
splitter -> split
aggregator -> aggregate
delayer -> delay
was (Author: davsclaus):
Well first of all the javadoc was wrong - I created a ticket CAMEL-1087
I thought the idea of this ticket was to use better wording (verbs) for the DSL
So for instance if you have a route like:
from(x).throttler(10).to(y)
Then when you read it in English it's not correct. It should be:
from(x).throttle(10).to(y)
The same applies for
splitter -> split
aggregator -> aggregate
delayer -> delay
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=46875#action_46875 ]
Claus Ibsen commented on CAMEL-64:
----------------------------------
This applies for the Spring DSL as well.
And I guess Gertv have used good names in his Scala DSL?
I guess we should only do this in the code when we have created the 1.x branch so trunk is 2.0.
Does it make sense to keep the old DSL as @deprecated. For the Spring DSL it would be really painful to keep the old and new DSL?
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-64) Camel DSL should use verbs for it's
EIP actions.
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=47672#action_47672 ]
Willem Jiang commented on CAMEL-64:
-----------------------------------
Changing the method name:
In the ProcessorType
splitter -> split *Done*
resequencer -> resequence *Done*
aggregator -> aggregate *Done*
delayer -> delay *Done*
throttler -> throttle *Done*
In the ExceptionType
delay -> setDelay *Done*
> Camel DSL should use verbs for it's EIP actions.
> -------------------------------------------------
>
> Key: CAMEL-64
> URL: https://issues.apache.org/activemq/browse/CAMEL-64
> Project: Apache Camel
> Issue Type: Improvement
> Components: camel-core
> Reporter: Hiram Chirino
> Assignee: Willem Jiang
> Fix For: 2.0.0
>
>
> For example splitter() should be split() and resequencer should be resequence.
> Old methods should be deprecated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.