You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by jo...@apache.org on 2021/12/18 14:57:50 UTC
[arrow] branch master updated: ARROW-15145: [R][CI] test-r-minimal-build fails due to updated error message
This is an automated email from the ASF dual-hosted git repository.
jonkeane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 836abb3 ARROW-15145: [R][CI] test-r-minimal-build fails due to updated error message
836abb3 is described below
commit 836abb35bd0c4b69e87d45cdbc2ddd3ec408003a
Author: Will Jones <wi...@gmail.com>
AuthorDate: Sat Dec 18 08:55:35 2021 -0600
ARROW-15145: [R][CI] test-r-minimal-build fails due to updated error message
Sorry I didn't test this well in previous PR. I have fixed the escape characters.
Closes #11988 from wjones127/ARROW-15145-fix-error-msg
Authored-by: Will Jones <wi...@gmail.com>
Signed-off-by: Jonathan Keane <jk...@gmail.com>
---
r/tests/testthat/test-feather.R | 6 ++++--
r/tests/testthat/test-parquet.R | 10 ++++++----
2 files changed, 10 insertions(+), 6 deletions(-)
diff --git a/r/tests/testthat/test-feather.R b/r/tests/testthat/test-feather.R
index f87cd91..80e9d09 100644
--- a/r/tests/testthat/test-feather.R
+++ b/r/tests/testthat/test-feather.R
@@ -235,8 +235,10 @@ test_that("Error messages are shown when the compression algorithm lz4 is not fo
msg <- paste0(
".*",
"you will need to reinstall arrow with additional features enabled.\nSet one of ",
- "these environment variables before installing:\n\n \\* Sys.setenv(LIBARROW_MINIMAL = \"false\") ",
- "\\(for all optional features, including 'lz4'\\)\n \\* Sys.setenv(ARROW_WITH_LZ4 = \"ON\") \\(for just 'lz4'\\)",
+ "these environment variables before installing:",
+ "\n\n \\* Sys\\.setenv\\(LIBARROW_MINIMAL = \"false\"\\) .*",
+ "\\(for all optional features, including 'lz4'\\)",
+ "\n \\* Sys\\.setenv\\(ARROW_WITH_LZ4 = \"ON\"\\) \\(for just 'lz4'\\)",
"\n\nSee https://arrow.apache.org/docs/r/articles/install.html for details"
)
diff --git a/r/tests/testthat/test-parquet.R b/r/tests/testthat/test-parquet.R
index fd5b6f8..c6533de 100644
--- a/r/tests/testthat/test-parquet.R
+++ b/r/tests/testthat/test-parquet.R
@@ -251,10 +251,12 @@ test_that("ParquetFileReader $ReadRowGroup(s) methods", {
test_that("Error messages are shown when the compression algorithm snappy is not found", {
msg <- paste0(
- "NotImplemented: Support for codec 'snappy' not built\nIn order to read this file, ",
+ ".*",
"you will need to reinstall arrow with additional features enabled.\nSet one of these ",
- "environment variables before installing:\n\n * Sys.setenv(LIBARROW_MINIMAL = \"false\") (for all optional ",
- "features, including 'snappy')\n * Sys.setenv(ARROW_WITH_SNAPPY = \"ON\") (for just 'snappy')\n\n",
+ "environment variables before installing:",
+ "\n\n \\* Sys\\.setenv\\(LIBARROW_MINIMAL = \"false\"\\) ",
+ "\\(for all optional features, including 'snappy'\\)",
+ "\n \\* Sys\\.setenv\\(ARROW_WITH_SNAPPY = \"ON\"\\) \\(for just 'snappy')\n\n",
"See https://arrow.apache.org/docs/r/articles/install.html for details"
)
@@ -262,7 +264,7 @@ test_that("Error messages are shown when the compression algorithm snappy is not
d <- read_parquet(pq_file)
expect_s3_class(d, "data.frame")
} else {
- expect_error(read_parquet(pq_file), msg, fixed = TRUE)
+ expect_error(read_parquet(pq_file), msg)
}
})