You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/12 08:21:10 UTC

[GitHub] [hudi] codope opened a new pull request, #5299: [WIP][HUDI-3819] Upgrade spring-core in hudi-cli

codope opened a new pull request, #5299:
URL: https://github.com/apache/hudi/pull/5299

   ## What is the purpose of the pull request
   
   To mitigate [CVE-2022-22965](https://tanzu.vmware.com/security/cve-2022-22965)
   The spring-shell has not been patched yet, however, I attempted to exclude spring-core from spring-shell and then explicitly add the patched spring-core. Builds fine but hudi-cli bootup fails due to:
   ```
   Exception in thread "main" java.lang.NoClassDefFoundError: org/springframework/core/ErrorCoded
   	at java.lang.ClassLoader.defineClass1(Native Method)
   	at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
   	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
   	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
   	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
   	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
   	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
   	at java.security.AccessController.doPrivileged(Native Method)
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
   	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
   	at java.lang.ClassLoader.defineClass1(Native Method)
   	at java.lang.ClassLoader.defineClass(ClassLoader.java:756)
   	at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
   	at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
   	at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
   	at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
   	at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
   	at java.security.AccessController.doPrivileged(Native Method)
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
   	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
   	at org.springframework.context.support.GenericApplicationContext.<init>(GenericApplicationContext.java:103)
   	at org.springframework.shell.Bootstrap.<init>(Bootstrap.java:87)
   	at org.springframework.shell.Bootstrap.<init>(Bootstrap.java:76)
   	at org.springframework.shell.Bootstrap.main(Bootstrap.java:58)
   Caused by: java.lang.ClassNotFoundException: org.springframework.core.ErrorCoded
   	at java.net.URLClassLoader.findClass(URLClassLoader.java:382)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:418)
   	at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:352)
   	at java.lang.ClassLoader.loadClass(ClassLoader.java:351)
   	... 28 more
   ```
   This PR needs some more work.
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5299: [WIP][HUDI-3819] Upgrade spring-core in hudi-cli

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5299:
URL: https://github.com/apache/hudi/pull/5299#issuecomment-1096481992

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6bca3f4d8e426f4196f1d080adbefd0790067bb9",
       "status" : "FAILURE",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8008",
       "triggerID" : "6bca3f4d8e426f4196f1d080adbefd0790067bb9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6bca3f4d8e426f4196f1d080adbefd0790067bb9 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8008) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5299: [WIP][HUDI-3819] Upgrade spring-core in hudi-cli

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5299:
URL: https://github.com/apache/hudi/pull/5299#issuecomment-1096350524

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6bca3f4d8e426f4196f1d080adbefd0790067bb9",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8008",
       "triggerID" : "6bca3f4d8e426f4196f1d080adbefd0790067bb9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6bca3f4d8e426f4196f1d080adbefd0790067bb9 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=8008) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [hudi] hudi-bot commented on pull request #5299: [WIP][HUDI-3819] Upgrade spring-core in hudi-cli

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5299:
URL: https://github.com/apache/hudi/pull/5299#issuecomment-1096344573

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "6bca3f4d8e426f4196f1d080adbefd0790067bb9",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "6bca3f4d8e426f4196f1d080adbefd0790067bb9",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 6bca3f4d8e426f4196f1d080adbefd0790067bb9 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org