You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by frido37 <gi...@git.apache.org> on 2015/07/17 10:32:18 UTC

[GitHub] wicket pull request: Add untouchPage() to PageManagerDecorator

GitHub user frido37 opened a pull request:

    https://github.com/apache/wicket/pull/132

    Add untouchPage() to PageManagerDecorator

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lindenbaum/wicket wicket-6.x

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
    
----
commit 62e0019f8aa28fc017da76885182e1db768a0a14
Author: Fridolin Jackstadt <fr...@lindenbaum.eu>
Date:   2015-07-17T08:25:36Z

    Add untouchPage() to PageManagerDecorator

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Add untouchPage() to PageManagerDecorator

Posted by frido37 <gi...@git.apache.org>.

Github user frido37 closed the pull request at:

    https://github.com/apache/wicket/pull/132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Add untouchPage() to PageManagerDecorator

Posted by martin-g <gi...@git.apache.org>.

Github user martin-g commented on a diff in the pull request:

    https://github.com/apache/wicket/pull/132#discussion_r34871244
  
    --- Diff: wicket-core/src/main/java/org/apache/wicket/page/PageManagerDecorator.java ---
    @@ -59,6 +59,14 @@ public void touchPage(IManageablePage page)
     		delegate.touchPage(page);
     	}
     
    +  public void untouchPage(IManageablePage page)
    --- End diff --
    
    Different whitespaces ...
    I'll make the change manually.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Add untouchPage() to PageManagerDecorator

Posted by martin-g <gi...@git.apache.org>.

Github user martin-g commented on the pull request:

    https://github.com/apache/wicket/pull/132#issuecomment-122218330
  
    Please close the PR. We don't have the rights.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] wicket pull request: Add untouchPage() to PageManagerDecorator

Posted by martin-g <gi...@git.apache.org>.

Github user martin-g commented on the pull request:

    https://github.com/apache/wicket/pull/132#issuecomment-122218268
  
    The change is applied!
    Thanks for testing before the release!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---