You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by marmbrus <gi...@git.apache.org> on 2015/04/03 02:46:47 UTC

[GitHub] spark pull request: [SPARK-5753] [SQL] add JDBCRDD support for pos...

Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/4549#issuecomment-89094918
  
    @liancheng, can you provide pointers here on how tests for postgres could be added?  I'd like to merge this feature, but I'm worried about doing it without tests.
    
    I'd be fine resurrecting the tests in apache (now that the release is over maybe we have more time to fix the dependency issues) as this would let us test patches like this more easily.
    
    @JoshRosen any idea if jenkins would support running docker based tests in the near future?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org