You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2022/01/27 18:23:24 UTC
[GitHub] [hadoop] ayushtkn opened a new pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
ayushtkn opened a new pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940
### Description of PR
Fixes creation of Delete Diff entry, the target in the delete diff should be null.
### How was this patch tested?
Added a UT
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#discussion_r803635894
##########
File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSync.java
##########
@@ -1154,6 +1155,80 @@ public void testSyncSnapshotDiffWithWebHdfs3() throws Exception {
snapshotDiffWithPaths(webHdfsSource, webHdfsTarget);
}
+ @Test
+ public void testRenameWithFilter() throws Exception {
+ java.nio.file.Path filterFile = null;
+ try {
+ Path sourcePath = new Path(dfs.getWorkingDirectory(), "source");
+
+ // Create some dir inside source
+ dfs.mkdirs(new Path(sourcePath, "dir1"));
+ dfs.mkdirs(new Path(sourcePath, "dir2"));
+
+ // Allow & Create snapshot at source.
+ dfs.allowSnapshot(sourcePath);
+ dfs.createSnapshot(sourcePath, "s1");
+
+ filterFile = Files.createTempFile("filters", "txt");
+ String str = ".*filterDir1.*";
+ try (BufferedWriter writer = new BufferedWriter(
+ new FileWriter(filterFile.toString()))) {
+ writer.write(str);
+ }
+ final DistCpOptions.Builder builder =
+ new DistCpOptions.Builder(new ArrayList<>(Arrays.asList(sourcePath)),
+ target).withFiltersFile(filterFile.toString())
+ .withSyncFolder(true);
+ new DistCp(conf, builder.build()).execute();
+
+ // Check the two directories get copied.
+ ContractTestUtils
+ .assertPathExists(dfs, "dir1 should get copied to target",
+ new Path(target, "dir1"));
+ ContractTestUtils
+ .assertPathExists(dfs, "dir2 should get copied to target",
+ new Path(target, "dir2"));
+
+ // Allow & create initial snapshots on target.
+ dfs.allowSnapshot(target);
+ dfs.createSnapshot(target, "s1");
+
+ // Now do a rename to a filtered name on source.
+ dfs.rename(new Path(sourcePath, "dir1"),
Review comment:
check result for non zero or that the dest file exists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on a change in pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#discussion_r803724330
##########
File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSync.java
##########
@@ -1154,6 +1155,80 @@ public void testSyncSnapshotDiffWithWebHdfs3() throws Exception {
snapshotDiffWithPaths(webHdfsSource, webHdfsTarget);
}
+ @Test
+ public void testRenameWithFilter() throws Exception {
+ java.nio.file.Path filterFile = null;
+ try {
+ Path sourcePath = new Path(dfs.getWorkingDirectory(), "source");
+
+ // Create some dir inside source
+ dfs.mkdirs(new Path(sourcePath, "dir1"));
+ dfs.mkdirs(new Path(sourcePath, "dir2"));
+
+ // Allow & Create snapshot at source.
+ dfs.allowSnapshot(sourcePath);
+ dfs.createSnapshot(sourcePath, "s1");
+
+ filterFile = Files.createTempFile("filters", "txt");
+ String str = ".*filterDir1.*";
+ try (BufferedWriter writer = new BufferedWriter(
+ new FileWriter(filterFile.toString()))) {
+ writer.write(str);
+ }
+ final DistCpOptions.Builder builder =
+ new DistCpOptions.Builder(new ArrayList<>(Arrays.asList(sourcePath)),
+ target).withFiltersFile(filterFile.toString())
+ .withSyncFolder(true);
+ new DistCp(conf, builder.build()).execute();
+
+ // Check the two directories get copied.
+ ContractTestUtils
+ .assertPathExists(dfs, "dir1 should get copied to target",
+ new Path(target, "dir1"));
+ ContractTestUtils
+ .assertPathExists(dfs, "dir2 should get copied to target",
+ new Path(target, "dir2"));
+
+ // Allow & create initial snapshots on target.
+ dfs.allowSnapshot(target);
+ dfs.createSnapshot(target, "s1");
+
+ // Now do a rename to a filtered name on source.
+ dfs.rename(new Path(sourcePath, "dir1"),
Review comment:
Done, Will push if tests are green
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn edited a comment on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
ayushtkn edited a comment on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1035009857
@saintstack
The path is actually relative:
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/protocol/SnapshotDiffReport.java#L85-L90
For rename entries it is made absolute here:
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L471-L474
For normal delete there won't be any target, it would be always ``null``, so it is added just like that in normal cases.
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L465-L468
In this particular case when using filters.
The actual entry is a ``RENAME`` entry which has target. Rename has to have a target. So, it takes this else block
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L254
And when converting it to a ``DELETE`` entry, it even adds the target.
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L262-L265
But since it is a delete entry the path isn't made absolute wrt target. So it stays like a relative path. like `filterDir1` and since it doesn't start with / and the normal logic by default it gets resolved to home directory.
Then the code that you shared does the magic, it moves it...
One example of target being set to ``null`` :
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L446-L447
May be there could be sanity check in delete diff for target, but not very confident about that part, will explore sometime if there is any use case possible where it can be not-null & compat stuff.
Further general optimisations as well are possible, like don't rename to tmp and then delete, directly delete(There is a reason why it is like that), that is something in my TODO list, will chase in future
General Info: Filters are like quite used in DR setups, some time we don't want to copy some data to replica clusters. One example could be Trash data, many other use cases as well.
Lemme know if it isn't still convincing..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1035511542
Thanx @saintstack @steveloughran and @sunchao for the help here.
I have posted the comment on the jira as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1035009857
@saintstack
The path is actually relative for rename entries it is made absolute here:
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L471-L474
For normal delete there won't be any target, it would be always ``null``, so it is added just like that in normal cases.
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L465-L468
In this particular case when using filters.
The actual entry is a ``RENAME`` entry which has target. Rename has to have a target. So, it takes this else block
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L254
And when converting it to a ``DELETE`` entry, it even adds the target.
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L262-L265
But since it is a delete entry the path isn't made absolute wrt target. So it stays like a relative path. like `filterDir1` and since it doesn't start with / and the normal logic by default it gets resolved to home directory.
Then the code that you shared does the magic, it moves it...
One example of target being set to ``null`` :
https://github.com/apache/hadoop/blob/efdec92cab8a88deb5ec9e81f5c8feb7a0fa873b/hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/DistCpSync.java#L446-L447
May be there could be sanity check in delete diff for target, but not very confident about that part, will explore sometime if there is any use case possible where it can be not-null & compat stuff.
Further general optimisations as well are possible, like don't rename to tmp and then delete, directly delete(There is a reason why it is like that), that is something in my TODO list, will chase in future
General Info: Filters are like quite used in DR setups, some time we don't want to copy some data to replica clusters. One example could be Trash data, many other use cases as well.
Lemme know if it isn't still convincing..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn commented on a change in pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
ayushtkn commented on a change in pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#discussion_r794497624
##########
File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSync.java
##########
@@ -1154,6 +1157,69 @@ public void testSyncSnapshotDiffWithWebHdfs3() throws Exception {
snapshotDiffWithPaths(webHdfsSource, webHdfsTarget);
}
+ @Test
+ public void testRenameWithFilter() throws Exception {
+ java.nio.file.Path filterFile = null;
+ try {
+ Path sourcePath = new Path(dfs.getWorkingDirectory(), "source");
+
+ // Create some dir inside source
+ dfs.mkdirs(new Path(sourcePath, "dir1"));
+ dfs.mkdirs(new Path(sourcePath, "dir2"));
+
+ // Allow & Create snapshot at source.
+ dfs.allowSnapshot(sourcePath);
+ dfs.createSnapshot(sourcePath, "s1");
+
+ filterFile = Files.createTempFile("filters", "txt");
+ String str = ".*filterDir1.*";
+ try (BufferedWriter writer = new BufferedWriter(
+ new FileWriter(filterFile.toString()))) {
+ writer.write(str);
+ }
+ final DistCpOptions.Builder builder =
+ new DistCpOptions.Builder(new ArrayList<>(Arrays.asList(sourcePath)),
+ target).withFiltersFile(filterFile.toString())
+ .withSyncFolder(true);
+ new DistCp(conf, builder.build()).execute();
+
+ // Check the two directories get copied.
+ assertTrue(dfs.exists(new Path(target, "dir1")));
+ assertTrue(dfs.exists(new Path(target, "dir2")));
+
+ // Allow & create initial snapshots on target.
+ dfs.allowSnapshot(target);
+ dfs.createSnapshot(target, "s1");
+
+ // Now do a rename to a filtered name on source.
+ dfs.rename(new Path(sourcePath, "dir1"),
+ new Path(sourcePath, "filterDir1"));
+
+ // Create the incremental snapshot.
+ dfs.createSnapshot(sourcePath, "s2");
+
+ final DistCpOptions.Builder diffBuilder =
+ new DistCpOptions.Builder(new ArrayList<>(Arrays.asList(sourcePath)),
+ target).withUseDiff("s1", "s2")
+ .withFiltersFile(filterFile.toString()).withSyncFolder(true);
+ new DistCp(conf, diffBuilder.build()).execute();
+
+ // Check the only qualified directory dir2 is there in target
+ assertTrue(dfs.exists(new Path(target, "dir2")));
Review comment:
Thanx @steveloughran for the review, Have changed it to use ``ContractTestUtils``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1024096920
looks like yarn won't build. not this patch's fault
```
[INFO]
[INFO] --- frontend-maven-plugin:1.11.2:yarn (yarn install) @ hadoop-yarn-applications-catalog-webapp ---
[INFO] testFailureIgnore property is ignored in non test phases
[INFO] Running 'yarn ' in /home/jenkins/jenkins-agent/workspace/hadoop-multibranch_PR-3940/ubuntu-focal/src/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/target
[INFO] yarn install v1.7.0
[INFO] info No lockfile found.
[INFO] [1/4] Resolving packages...
[INFO] [2/4] Fetching packages...
[INFO] error safe-stable-stringify@2.3.1: The engine "node" is incompatible with this module. Expected version ">=10".
[INFO] error Found incompatible module
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1026235951
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 23s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 39m 22s | | trunk passed |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 30s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 26s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 31s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 28s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 57s | | trunk passed |
| +1 :green_heart: | shadedclient | 27m 2s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 30s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 30s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 28s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 1m 5s | | the patch passed |
| +1 :green_heart: | shadedclient | 26m 9s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 42m 5s | | hadoop-distcp in the patch passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not generate ASF License warnings. |
| | | 146m 14s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/3/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3940 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 246f98f9a681 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 834ea60b8eff295384f08b2655ded2773d475870 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/3/testReport/ |
| Max. process+thread count | 722 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/3/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1031795923
I'm not very familiar with the HDFS snapshot feature so can't help much with the reviewing here. cc @bshashikant @steveloughran : could you review this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sunchao edited a comment on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
sunchao edited a comment on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1035184271
Thanks @steveloughran and @saintstack for the review! @ayushtkn could you merge this and backport to branch-3.3.2? I'll kick off 3.3.2 RC4 right after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] ayushtkn merged pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
ayushtkn merged pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] steveloughran commented on a change in pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
steveloughran commented on a change in pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#discussion_r794396150
##########
File path: hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSync.java
##########
@@ -1154,6 +1157,69 @@ public void testSyncSnapshotDiffWithWebHdfs3() throws Exception {
snapshotDiffWithPaths(webHdfsSource, webHdfsTarget);
}
+ @Test
+ public void testRenameWithFilter() throws Exception {
+ java.nio.file.Path filterFile = null;
+ try {
+ Path sourcePath = new Path(dfs.getWorkingDirectory(), "source");
+
+ // Create some dir inside source
+ dfs.mkdirs(new Path(sourcePath, "dir1"));
+ dfs.mkdirs(new Path(sourcePath, "dir2"));
+
+ // Allow & Create snapshot at source.
+ dfs.allowSnapshot(sourcePath);
+ dfs.createSnapshot(sourcePath, "s1");
+
+ filterFile = Files.createTempFile("filters", "txt");
+ String str = ".*filterDir1.*";
+ try (BufferedWriter writer = new BufferedWriter(
+ new FileWriter(filterFile.toString()))) {
+ writer.write(str);
+ }
+ final DistCpOptions.Builder builder =
+ new DistCpOptions.Builder(new ArrayList<>(Arrays.asList(sourcePath)),
+ target).withFiltersFile(filterFile.toString())
+ .withSyncFolder(true);
+ new DistCp(conf, builder.build()).execute();
+
+ // Check the two directories get copied.
+ assertTrue(dfs.exists(new Path(target, "dir1")));
+ assertTrue(dfs.exists(new Path(target, "dir2")));
+
+ // Allow & create initial snapshots on target.
+ dfs.allowSnapshot(target);
+ dfs.createSnapshot(target, "s1");
+
+ // Now do a rename to a filtered name on source.
+ dfs.rename(new Path(sourcePath, "dir1"),
+ new Path(sourcePath, "filterDir1"));
+
+ // Create the incremental snapshot.
+ dfs.createSnapshot(sourcePath, "s2");
+
+ final DistCpOptions.Builder diffBuilder =
+ new DistCpOptions.Builder(new ArrayList<>(Arrays.asList(sourcePath)),
+ target).withUseDiff("s1", "s2")
+ .withFiltersFile(filterFile.toString()).withSyncFolder(true);
+ new DistCp(conf, diffBuilder.build()).execute();
+
+ // Check the only qualified directory dir2 is there in target
+ assertTrue(dfs.exists(new Path(target, "dir2")));
Review comment:
use the ContractTestUtils asserts here as they report on failures, including with dir listing info
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1035217384
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 16m 48s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 1s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 88m 54s | | trunk passed |
| +1 :green_heart: | compile | 0m 34s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 31s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 27s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 58s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 30s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 50s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 10s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 27s | | the patch passed |
| +1 :green_heart: | compile | 0m 26s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 26s | | the patch passed |
| +1 :green_heart: | compile | 0m 23s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 23s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 17s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 26s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 21s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 19s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 50s | | the patch passed |
| +1 :green_heart: | shadedclient | 19m 54s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 39m 36s | | hadoop-distcp in the patch passed. |
| +1 :green_heart: | asflicense | 0m 35s | | The patch does not generate ASF License warnings. |
| | | 195m 16s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/4/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3940 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 27a70ca30267 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 25cf63c38c5e4bd29cb7a720688bf7cfd2f01951 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/4/testReport/ |
| Max. process+thread count | 674 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/4/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] sunchao commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
sunchao commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1035184271
Thanks @steveloughran and @saintstack for the review! @ayushtkn could you merge this and backport to branch-3.2? I'll kick off 3.3.2 RC4 right after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1023745783
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 0m 46s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| -1 :x: | mvninstall | 40m 14s | [/branch-mvninstall-root.txt](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/1/artifact/out/branch-mvninstall-root.txt) | root in trunk failed. |
| +1 :green_heart: | compile | 0m 36s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 28s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 24s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 28s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 26s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 56s | | trunk passed |
| +1 :green_heart: | shadedclient | 26m 38s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 31s | | the patch passed |
| +1 :green_heart: | compile | 0m 29s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 29s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 16s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 27s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 22s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 20s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 1m 2s | | the patch passed |
| +1 :green_heart: | shadedclient | 27m 3s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 25m 47s | | hadoop-distcp in the patch passed. |
| +1 :green_heart: | asflicense | 0m 33s | | The patch does not generate ASF License warnings. |
| | | 130m 20s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/1/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3940 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux 5655abca203d 4.15.0-156-generic #163-Ubuntu SMP Thu Aug 19 23:31:58 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / f7596259eef03962c4fb0f8f279bcc44efada35a |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/1/testReport/ |
| Max. process+thread count | 719 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/1/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org
[GitHub] [hadoop] hadoop-yetus commented on pull request #3940: HADOOP-18096. Distcp: Sync moves filtered file to home directory rather than deleting.
Posted by GitBox <gi...@apache.org>.
hadoop-yetus commented on pull request #3940:
URL: https://github.com/apache/hadoop/pull/3940#issuecomment-1024218074
:confetti_ball: **+1 overall**
| Vote | Subsystem | Runtime | Logfile | Comment |
|:----:|----------:|--------:|:--------:|:-------:|
| +0 :ok: | reexec | 1m 18s | | Docker mode activated. |
|||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | | No case conflicting files found. |
| +0 :ok: | codespell | 0m 0s | | codespell was not available. |
| +1 :green_heart: | @author | 0m 0s | | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | | The patch appears to include 1 new or modified test files. |
|||| _ trunk Compile Tests _ |
| +1 :green_heart: | mvninstall | 31m 13s | | trunk passed |
| +1 :green_heart: | compile | 0m 34s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | compile | 0m 32s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | checkstyle | 0m 27s | | trunk passed |
| +1 :green_heart: | mvnsite | 0m 36s | | trunk passed |
| +1 :green_heart: | javadoc | 0m 30s | | trunk passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 29s | | trunk passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 50s | | trunk passed |
| +1 :green_heart: | shadedclient | 20m 33s | | branch has no errors when building and testing our client artifacts. |
|||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 0m 27s | | the patch passed |
| +1 :green_heart: | compile | 0m 25s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javac | 0m 25s | | the patch passed |
| +1 :green_heart: | compile | 0m 22s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | javac | 0m 22s | | the patch passed |
| +1 :green_heart: | blanks | 0m 0s | | The patch has no blanks issues. |
| +1 :green_heart: | checkstyle | 0m 15s | | the patch passed |
| +1 :green_heart: | mvnsite | 0m 24s | | the patch passed |
| +1 :green_heart: | javadoc | 0m 18s | | the patch passed with JDK Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 |
| +1 :green_heart: | javadoc | 0m 17s | | the patch passed with JDK Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| +1 :green_heart: | spotbugs | 0m 51s | | the patch passed |
| +1 :green_heart: | shadedclient | 20m 7s | | patch has no errors when building and testing our client artifacts. |
|||| _ Other Tests _ |
| +1 :green_heart: | unit | 38m 7s | | hadoop-distcp in the patch passed. |
| +1 :green_heart: | asflicense | 0m 34s | | The patch does not generate ASF License warnings. |
| | | 120m 35s | | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/2/artifact/out/Dockerfile |
| GITHUB PR | https://github.com/apache/hadoop/pull/3940 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient spotbugs checkstyle codespell |
| uname | Linux fa2df03d1862 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev-support/bin/hadoop.sh |
| git revision | trunk / 834ea60b8eff295384f08b2655ded2773d475870 |
| Default Java | Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Multi-JDK versions | /usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.13+8-Ubuntu-0ubuntu1.20.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_312-8u312-b07-0ubuntu1~20.04-b07 |
| Test Results | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/2/testReport/ |
| Max. process+thread count | 549 (vs. ulimit of 5500) |
| modules | C: hadoop-tools/hadoop-distcp U: hadoop-tools/hadoop-distcp |
| Console output | https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3940/2/console |
| versions | git=2.25.1 maven=3.6.3 spotbugs=4.2.2 |
| Powered by | Apache Yetus 0.14.0-SNAPSHOT https://yetus.apache.org |
This message was automatically generated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org