You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "DevPJ9 (via GitHub)" <gi...@apache.org> on 2023/04/06 16:44:45 UTC
[GitHub] [beam] DevPJ9 opened a new pull request, #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
DevPJ9 opened a new pull request, #26154:
URL: https://github.com/apache/beam/pull/26154
Description :
**Please** add a meaningful description for your change here
Added a the description point `<p>Note that: The implementations of this interface should be encodable (have an associated Coder)` about UnboundedSource.CheckpointMark. fixes #19708
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] DevPJ9 commented on a diff in pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on code in PR #26154:
URL: https://github.com/apache/beam/pull/26154#discussion_r1164313391
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java:
##########
@@ -100,6 +100,8 @@ public boolean requiresDeduping() {
* org.apache.beam.sdk.io.UnboundedSource.UnboundedReader}.
*
* <p>For example, this could be offsets in a set of files being read.
+ *
+ * <p>Note that: The implementations of this interface should be encodable (have an associated Coder).
Review Comment:
Ok. sure. Commiting the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1501834860
Rerunning some flaky test suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505272656
Run Java_Kinesis_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1501835173
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1501834967
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] DevPJ9 commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505358652
> Sorry, coming back to this - we had a CI outage that kept me from merging before and distracted my attention
No problem at all, I completely understand. Thank you for keeping me informed about the situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] DevPJ9 closed pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 closed pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
URL: https://github.com/apache/beam/pull/26154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1501835074
Run Java_Kinesis_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm merged pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #26154:
URL: https://github.com/apache/beam/pull/26154
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1499368038
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] DevPJ9 commented on a diff in pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on code in PR #26154:
URL: https://github.com/apache/beam/pull/26154#discussion_r1164308216
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java:
##########
@@ -100,6 +100,8 @@ public boolean requiresDeduping() {
* org.apache.beam.sdk.io.UnboundedSource.UnboundedReader}.
*
* <p>For example, this could be offsets in a set of files being read.
+ *
+ * <p>Note that: The implementations of this interface should be encodable (have an associated Coder).
Review Comment:
Ok. should I commit again after executing `./gradlew :sdks:java:core:spotlessApply` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505272394
Sorry, coming back to this - we had a CI outage that kept me from merging before and distracted my attention
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505272844
Run Java_GCP_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505649395
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505272506
Run Spotless PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26154:
URL: https://github.com/apache/beam/pull/26154#discussion_r1164261240
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java:
##########
@@ -100,6 +100,8 @@ public boolean requiresDeduping() {
* org.apache.beam.sdk.io.UnboundedSource.UnboundedReader}.
*
* <p>For example, this could be offsets in a set of files being read.
+ *
+ * <p>Note that: The implementations of this interface should be encodable (have an associated Coder).
Review Comment:
```suggestion
* <p>Note that: The implementations of this interface should be encodable (have an associated
* Coder).
```
Our linter flagged this as exceeding our line limit - https://ci-beam.apache.org/job/beam_PreCommit_Spotless_Commit/26268/console
You can also run `./gradlew :sdks:java:core:spotlessApply` from the repo root to apply fixes like this in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] damccorm commented on a diff in pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #26154:
URL: https://github.com/apache/beam/pull/26154#discussion_r1164309397
##########
sdks/java/core/src/main/java/org/apache/beam/sdk/io/UnboundedSource.java:
##########
@@ -100,6 +100,8 @@ public boolean requiresDeduping() {
* org.apache.beam.sdk.io.UnboundedSource.UnboundedReader}.
*
* <p>For example, this could be offsets in a set of files being read.
+ *
+ * <p>Note that: The implementations of this interface should be encodable (have an associated Coder).
Review Comment:
Yep, you can either do that locally and commit to the same branch, or you can just click `commit suggestion` this time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] DevPJ9 commented on pull request #26154: Added checkpoints description. Resolves : Improve checkpoints documentation #19708
Posted by "DevPJ9 (via GitHub)" <gi...@apache.org>.
DevPJ9 commented on PR #26154:
URL: https://github.com/apache/beam/pull/26154#issuecomment-1505360252
Sorry, I pressed the `close with comment` button by mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org