[superset] 01/02: chore: use util test env for init check (#23325)

[el...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

elizabeth pushed a commit to branch 2.1
in repository https://gitbox.apache.org/repos/asf/superset.git

commit d19d298d9d9ea3cd5e72e1436d03cb2ea4bb737e
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Fri Mar 10 16:07:50 2023 -0800

    chore: use util test env for init check (#23325)
---
 .github/workflows/superset-python-unittest.yml | 2 ++
 superset/initialization/__init__.py            | 5 ++---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/superset-python-unittest.yml b/.github/workflows/superset-python-unittest.yml
index 1ff07375d4..8c94d0f458 100644
--- a/.github/workflows/superset-python-unittest.yml
+++ b/.github/workflows/superset-python-unittest.yml
@@ -50,6 +50,8 @@ jobs:
             mkdir ${{ github.workspace }}/.temp
       - name: Python unit tests
         if: steps.check.outcome == 'failure'
+        env:
+          SUPERSET_TESTENV: true
         run: |
           pytest --durations-min=0.5 --cov-report= --cov=superset ./tests/common ./tests/unit_tests --cache-clear
       - name: Upload code coverage
diff --git a/superset/initialization/__init__.py b/superset/initialization/__init__.py
index c01ee7ba09..ef332e502d 100644
--- a/superset/initialization/__init__.py
+++ b/superset/initialization/__init__.py
@@ -53,7 +53,7 @@ from superset.extensions import (
 from superset.security import SupersetSecurityManager
 from superset.superset_typing import FlaskResponse
 from superset.tags.core import register_sqla_event_listeners
-from superset.utils.core import pessimistic_connection_handling
+from superset.utils.core import is_test, pessimistic_connection_handling
 from superset.utils.log import DBEventLogger, get_event_logger_from_cfg_value
 
 if TYPE_CHECKING:
@@ -457,8 +457,7 @@ class SupersetAppInitializer:  # pylint: disable=too-many-public-methods
             if (
                 self.superset_app.debug
                 or self.superset_app.config["TESTING"]
-                # There must be a better way
-                or "pytest" in sys.modules
+                or is_test()
             ):
                 logger.warning("Debug mode identified with default secret key")
                 log_default_secret_key_warning()