You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "HolyLow (via GitHub)" <gi...@apache.org> on 2025/04/07 08:13:03 UTC

[PR] [CELEBORN-1958][CIP-14] Add testsuite to test writing with javaClient and reading with cppClient [celeborn]

HolyLow opened a new pull request, #3202:
URL: https://github.com/apache/celeborn/pull/3202

   ### What changes were proposed in this pull request?
   This PR adds joint test suite between java and cpp code, which test writing data with javaClient and reading with cppClient.
   
   ### Why are the changes needed?
   The joint test suite could be used to verify the cppClient's correctness.
   
   ### Does this PR introduce _any_ user-facing change?
   No.
   
   ### How was this patch tested?
   Compilation and manual test.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1958][CIP-14] Add testsuite to test writing with javaClient and reading with cppClient [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX closed pull request #3202: [CELEBORN-1958][CIP-14] Add testsuite to test writing with javaClient and reading with cppClient
URL: https://github.com/apache/celeborn/pull/3202


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1958][CIP-14] Add testsuite to test writing with javaClient and reading with cppClient [celeborn]

Posted by "FMX (via GitHub)" <gi...@apache.org>.
FMX commented on PR #3202:
URL: https://github.com/apache/celeborn/pull/3202#issuecomment-2795916825

   Maybe we can try to use the Docker image to run the CIs.
   https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#jobsjob_idcontainer


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1958][CIP-14] Add testsuite to test writing with javaClient and reading with cppClient [celeborn]

Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on PR #3202:
URL: https://github.com/apache/celeborn/pull/3202#issuecomment-2804091377

   @FMX @RexXiong Now the test suite is integrated into the CICD procedure.
   
   Any further suggestion is welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1958][CIP-14] Add testsuite to test writing with javaClient and reading with cppClient [celeborn]

Posted by "HolyLow (via GitHub)" <gi...@apache.org>.
HolyLow commented on PR #3202:
URL: https://github.com/apache/celeborn/pull/3202#issuecomment-2782410740

   @FMX @RexXiong Could you kindly help review this PR? Thanks a lot.
   
   There are several notations for triggering this PR's test:
   
   1. The cpp code must be compiled under $projectRoot/cpp/build. The sample command would be:
   ```
   # assume currentDir is $projectRoot
   $ cd cpp; rm -rf build && mkdir build && cd build && cmake .. && make -j
   ```
   2. The test suite is marked by @Ignored to avoid influencing existing CICD procedure. To test it manually, we have to remove the @Ignored tag manually.
   
   Any suggestion is welcome.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org