You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2017/04/03 18:00:45 UTC
Re: Review Request 58083: AMBARI-20625. Hadoop QA javac warnings
increase check is broken -- fix for ambari-server
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58083/#review170905
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On April 3, 2017, 1:49 p.m., Attila Doroszlai wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58083/
> -----------------------------------------------------------
>
> (Updated April 3, 2017, 1:49 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Sandor Magyari, and Sebastian Toader.
>
>
> Bugs: AMBARI-20625
> https://issues.apache.org/jira/browse/AMBARI-20625
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Added `-Xlint:all` flag. Currently this has effect only on `ambari-server` module.
>
>
> Diffs
> -----
>
> dev-support/test-patch.sh 661f871c6cce927688f17d1aa77aba37eae9bbe6
>
>
> Diff: https://reviews.apache.org/r/58083/diff/1/
>
>
> Testing
> -------
>
> Tested with patch that increased the number of warnings, got:
>
> ```
> {color:red}-1 javac{color}. The applied patch generated 496 javac compiler warnings (more than the trunk's current 494 warnings).
> ```
>
>
> Thanks,
>
> Attila Doroszlai
>
>