You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2021/02/10 13:36:29 UTC

[GitHub] [calcite] Dominick1993 commented on a change in pull request #2346: [CALCITE-4491] Aggregations of nested window functions

Dominick1993 commented on a change in pull request #2346:
URL: https://github.com/apache/calcite/pull/2346#discussion_r573730700



##########
File path: core/src/main/java/org/apache/calcite/rel/rel2sql/SqlImplementor.java
##########
@@ -1803,9 +1805,14 @@ private boolean needNewSubQuery(
 
       if (rel instanceof Aggregate) {
         final Aggregate agg = (Aggregate) rel;
-        final boolean hasNestedAgg = hasNestedAggregations(agg);
+        final boolean hasNestedAgg = hasNested(agg, operand ->
+            operand instanceof SqlCall

Review comment:
       @julianhyde I wasn't sure whether this check should be a part of `hasNested` method or a part of the predicate. I've chosen to go with the more generic predicate approach here, but please let me know your preference.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org