[GitHub] [spark] cloud-fan commented on a change in pull request #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24546: [SPARK-27650][SQL] separate the row iterator functionality from ColumnarBatch
URL: https://github.com/apache/spark/pull/24546#discussion_r282039973
 
 

 ##########
 File path: sql/core/src/main/java/org/apache/spark/sql/vectorized/ColumnarBatch.java
 ##########
 @@ -16,25 +16,17 @@
  */
 package org.apache.spark.sql.vectorized;
 
-import java.util.*;
-
 import org.apache.spark.annotation.Evolving;
-import org.apache.spark.sql.catalyst.InternalRow;
-import org.apache.spark.sql.execution.vectorized.MutableColumnarRow;
 
 /**
- * This class wraps multiple ColumnVectors as a row-wise table. It provides a row view of this
- * batch so that Spark can access the data row by row. Instance of it is meant to be reused during
- * the entire data loading process.
+ * This class wraps multiple {@link ColumnVector}s as a table-like data batch. Instance of it is
+ * meant to be reused during the entire data loading process.
  */
 @Evolving
 public final class ColumnarBatch {
   private int numRows;
 
 Review comment:
   Spark needs to know the row count to read the columnar data.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org