[GitHub] [drill] HanumathRao commented on a change in pull request #1677: DRILL-7068: Support memory adjustment framework for resource manageme…

[GitBox <gi...@apache.org>]

HanumathRao commented on a change in pull request #1677: DRILL-7068: Support memory adjustment framework for resource manageme…
URL: https://github.com/apache/drill/pull/1677#discussion_r263651069
 
 

 ##########
 File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/PrelCostEstimates.java
 ##########
 @@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.planner.cost;
+
+import com.fasterxml.jackson.annotation.JsonProperty;
+import com.fasterxml.jackson.annotation.JsonTypeName;
+
+/**
+ * Cost estimates per physical relation. These cost estimations are computed
+ * during physical planning by the optimizer. These are also used post physical
+ * planning to compute memory requirements in minor fragment generation phase.
+ *
+ */
+@JsonTypeName("cost-estimates")
+public class PrelCostEstimates {
+  // memory requirement for an operator.
+  private final double memoryCost;
 
 Review comment:
   I don't think using NodeResources makes sense here, generally NodeResources pertains to resources per Node. However, I do agree that some other class (like Resources) might make sense which can encapsulate memory, cpu etc but as we are currently concerned only with memory for now, I thought this can be further enhanced whenever we think it might make sense to pass on other important information.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services