You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by Giorgio Zoppi <gi...@gmail.com> on 2020/05/13 19:34:12 UTC
Thrift .NET Core binding
Dear all,
i have created an initial .NET Core binding with Jetbrains Raider on
Linux, before testing i would like how should i proceed.
- should i create a separate repo as we are doing with the native
project, or should i ask for a pull request, in order to be integrated?
Currently i branched out locally with iotdb-net.
BR,
Giorgio.
Re: Thrift .NET Core binding
Posted by Giorgio Zoppi <gi...@gmail.com>.
On 5/14/20 1:00 PM, Xiangdong Huang wrote:
> Hi Giorgio,
>
> Is this an RPC client for connecting with IoTDB?
>
> If so, I think submit a PR and put it into Apache IoTDB repo is better (if
> you decide to donate the codes to ASF).
Yes, i will mantain the repo, currently have all but i need to test it a
bit more. I can't connect :)
It is a .NET core Linux client to your database, and i will mantain a
separate lib.
Best Regards,
Giorgio
Re: Thrift .NET Core binding
Posted by Giorgio Zoppi <gi...@gmail.com>.
Hi all,
yes i have already signed the Apache CCLA many years ago. I added the
Apache License *.csproj.
They are just convenient for compiling, otherwise a user should generate
again every time.
BR,
Giorgio
Re: Thrift .NET Core binding
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi,
although the file is initially generated by VS Code we should add an Apache Header. In my understanding its somewhat similar to mvn file (at least a part of it).
Another question @Giorgio Zoppi: You already filed an Apache CCLA as you are already committer, right?
Julian
Am 17.05.20, 09:45 schrieb "Giorgio Zoppi" <gi...@gmail.com>:
On 5/17/20 6:22 AM, Xiangdong Huang wrote:
> Hi,
>
> In this PR, the source files contain "*.csproj" file. I believe it is
> generated by Visual Studio or VS Code.
>
> So, do we need to add apache-rat in such files? Or exclude them when
> checking apache-rat?
I added the apache header in both/ and including in the readme.
> Besides, is there another way to maintain the dot net project
> structure without ".csproj"?
No, there is no way out of the box in .net working without project files.
BR,
Giorgio.
Re: Thrift .NET Core binding
Posted by Giorgio Zoppi <gi...@gmail.com>.
On 5/17/20 6:22 AM, Xiangdong Huang wrote:
> Hi,
>
> In this PR, the source files contain "*.csproj" file. I believe it is
> generated by Visual Studio or VS Code.
>
> So, do we need to add apache-rat in such files? Or exclude them when
> checking apache-rat?
I added the apache header in both/ and including in the readme.
> Besides, is there another way to maintain the dot net project
> structure without ".csproj"?
No, there is no way out of the box in .net working without project files.
BR,
Giorgio.
Re: Thrift .NET Core binding
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,
In this PR, the source files contain "*.csproj" file. I believe it is
generated by Visual Studio or VS Code.
So, do we need to add apache-rat in such files? Or exclude them when
checking apache-rat?
Besides, is there another way to maintain the dot net project structure
without ".csproj"?
I CC to Chris and Justin, as I think they may have experience..
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Giorgio Zoppi <gi...@gmail.com> 于2020年5月17日周日 上午4:25写道：
> Done PR
>
> https://github.com/apache/incubator-iotdb/pull/1217
>
> BR,
>
> Giorgio
>
>
>
Re: Thrift .NET Core binding
Posted by Giorgio Zoppi <gi...@gmail.com>.
Done PR
https://github.com/apache/incubator-iotdb/pull/1217
BR,
Giorgio
Re: Thrift .NET Core binding
Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi,
something we could probably contribute, with the help of @Christofer Dutz is to make a build that is able to build all languages which is really nice from CI perspective.
He did most oft hat already for PLC4X and we could copy a lot there, I think.
Julian
Am 14.05.20, 13:01 schrieb "Xiangdong Huang" <sa...@gmail.com>:
Hi Giorgio,
Is this an RPC client for connecting with IoTDB?
If so, I think submit a PR and put it into Apache IoTDB repo is better (if
you decide to donate the codes to ASF).
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Giorgio Zoppi <gi...@gmail.com> 于2020年5月14日周四 上午3:34写道：
> Dear all,
>
> i have created an initial .NET Core binding with Jetbrains Raider on
> Linux, before testing i would like how should i proceed.
>
> - should i create a separate repo as we are doing with the native
> project, or should i ask for a pull request, in order to be integrated?
>
> Currently i branched out locally with iotdb-net.
>
> BR,
>
> Giorgio.
>
>
>
Re: Thrift .NET Core binding
Posted by Xiangdong Huang <sa...@gmail.com>.
Hi Giorgio,
Is this an RPC client for connecting with IoTDB?
If so, I think submit a PR and put it into Apache IoTDB repo is better (if
you decide to donate the codes to ASF).
Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University
黄向东
清华大学 软件学院
Giorgio Zoppi <gi...@gmail.com> 于2020年5月14日周四 上午3:34写道：
> Dear all,
>
> i have created an initial .NET Core binding with Jetbrains Raider on
> Linux, before testing i would like how should i proceed.
>
> - should i create a separate repo as we are doing with the native
> project, or should i ask for a pull request, in order to be integrated?
>
> Currently i branched out locally with iotdb-net.
>
> BR,
>
> Giorgio.
>
>
>