[GitHub] [kafka] kkonstantine commented on a change in pull request #10152: KAFKA-12339 Starting new connector cluster with new internal topics e…

[GitBox <gi...@apache.org>]

kkonstantine commented on a change in pull request #10152:
URL: https://github.com/apache/kafka/pull/10152#discussion_r579485651



##########
File path: clients/src/main/java/org/apache/kafka/clients/admin/internals/MetadataOperationContext.java
##########
@@ -82,6 +82,7 @@ public long deadline() {
 
     public static void handleMetadataErrors(MetadataResponse response) {
         for (TopicMetadata tm : response.topicMetadata()) {
+            if (shouldRefreshMetadata(tm.error())) throw tm.error().exception();

Review comment:
       nit: a stylistic observation is that this call is exactly the same as the call below. Yet it's written differently. 
   
   Styles differ, usually not too much, from module to module. I think it's good to keep existing styles to help with readability and when the changes don't require a greater change. 
    
   ```suggestion
               if (shouldRefreshMetadata(tm.error())) { 
                   throw tm.error().exception();
               }
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org