You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by Christoph Nenning <Ch...@lex-com.net> on 2016/09/28 08:48:37 UTC
Re: [jira] [Commented] (WW-4628) Space character and includeParams
Why was this reverted?
Obviously the revert was part of PR 108, but why?
"ASF subversion and git services (JIRA)" <ji...@apache.org> schrieb am
28.09.2016 10:37:21:
> From: "ASF subversion and git services (JIRA)" <ji...@apache.org>
> To: issues@struts.apache.org,
> Date: 28.09.2016 10:37
> Subject: [jira] [Commented] (WW-4628) Space character and includeParams
>
>
> [ https://issues.apache.org/jira/browse/WW-4628?
> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
> tabpanel&focusedCommentId=15528913#comment-15528913 ]
>
> ASF subversion and git services commented on WW-4628:
> -----------------------------------------------------
>
> Commit d9fe1406ee287226704fdd5e3a53d59e6b0a556f in struts's branch
> refs/heads/master from [~ghuber]
> [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d9fe140 ]
>
> Revert "WW-4628: proper decoding of parameters in query-string"
>
> This reverts commit ef9c66118ede16f3ff239ea864641d5bdadeecae.
>
>
> > Space character and includeParams
> > ---------------------------------
> >
> > Key: WW-4628
> > URL: https://issues.apache.org/jira/browse/WW-4628
> > Project: Struts 2
> > Issue Type: Bug
> > Affects Versions: 2.3.28
> > Reporter: Pierre-Yves Soblet
> > Assignee: Christoph Nenning
> > Fix For: 2.3.31, 2.5.3
> >
> > Attachments: Struts2UrlTest.zip
> >
> >
> > With this JSP snippet using Struts 2 taglib:
> > {code}
> > myParameter=[<s:property value="%{#parameters['myParameter']}"/>]
> > <br/>
> > <s:url action="url" includeParams="get"/>
> > <br/>
> > <s:url action="url">
> > <s:param name="myParameter"
value="%{#parameters['myParameter']}"/>
> > </s:url>
> > {code}
> > When the action is called with a parameter containing a space
> (which is escaped in the URL) :
> > {code}
> > localhost:8080/url?myParameter=with+space
> > {code}
> > The output is as follows :
> > {code}
> > myParameter=[with space]
> > /url.action?myParameter=with%2Bspace
> > /url.action?myParameter=with+space
> > {code}
> > The *includeParams* attribute of the “url” tag seems to transform
> the "space" character into the "plus" character (both in their url-
> encoded forms).
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.3.4#6332)
This Email was scanned by Sophos Anti Virus
Re: [jira] [Commented] (WW-4628) Space character and includeParams
Posted by Lukasz Lenart <lu...@apache.org>.
Because of reverse merges - it happens when you do merge the `master`
back into your PR branch. I'm trying to avoid doing such till I don't
have conflicts.
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
2016-09-28 10:48 GMT+02:00 Christoph Nenning <Ch...@lex-com.net>:
> Why was this reverted?
>
> Obviously the revert was part of PR 108, but why?
>
>
>
>
> "ASF subversion and git services (JIRA)" <ji...@apache.org> schrieb am
> 28.09.2016 10:37:21:
>
>> From: "ASF subversion and git services (JIRA)" <ji...@apache.org>
>> To: issues@struts.apache.org,
>> Date: 28.09.2016 10:37
>> Subject: [jira] [Commented] (WW-4628) Space character and includeParams
>>
>>
>> [ https://issues.apache.org/jira/browse/WW-4628?
>> page=com.atlassian.jira.plugin.system.issuetabpanels:comment-
>> tabpanel&focusedCommentId=15528913#comment-15528913 ]
>>
>> ASF subversion and git services commented on WW-4628:
>> -----------------------------------------------------
>>
>> Commit d9fe1406ee287226704fdd5e3a53d59e6b0a556f in struts's branch
>> refs/heads/master from [~ghuber]
>> [ https://git-wip-us.apache.org/repos/asf?p=struts.git;h=d9fe140 ]
>>
>> Revert "WW-4628: proper decoding of parameters in query-string"
>>
>> This reverts commit ef9c66118ede16f3ff239ea864641d5bdadeecae.
>>
>>
>> > Space character and includeParams
>> > ---------------------------------
>> >
>> > Key: WW-4628
>> > URL: https://issues.apache.org/jira/browse/WW-4628
>> > Project: Struts 2
>> > Issue Type: Bug
>> > Affects Versions: 2.3.28
>> > Reporter: Pierre-Yves Soblet
>> > Assignee: Christoph Nenning
>> > Fix For: 2.3.31, 2.5.3
>> >
>> > Attachments: Struts2UrlTest.zip
>> >
>> >
>> > With this JSP snippet using Struts 2 taglib:
>> > {code}
>> > myParameter=[<s:property value="%{#parameters['myParameter']}"/>]
>> > <br/>
>> > <s:url action="url" includeParams="get"/>
>> > <br/>
>> > <s:url action="url">
>> > <s:param name="myParameter"
> value="%{#parameters['myParameter']}"/>
>> > </s:url>
>> > {code}
>> > When the action is called with a parameter containing a space
>> (which is escaped in the URL) :
>> > {code}
>> > localhost:8080/url?myParameter=with+space
>> > {code}
>> > The output is as follows :
>> > {code}
>> > myParameter=[with space]
>> > /url.action?myParameter=with%2Bspace
>> > /url.action?myParameter=with+space
>> > {code}
>> > The *includeParams* attribute of the “url” tag seems to transform
>> the "space" character into the "plus" character (both in their url-
>> encoded forms).
>>
>>
>>
>> --
>> This message was sent by Atlassian JIRA
>> (v6.3.4#6332)
>
>
> This Email was scanned by Sophos Anti Virus
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org