You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Dmytro Sen <ds...@hortonworks.com> on 2017/07/27 11:52:46 UTC

Review Request 61177: Don't set restart indicators for NN/RM during DN/NM deletion

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61177/
-----------------------------------------------------------

Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-21587
    https://issues.apache.org/jira/browse/AMBARI-21587


Repository: ambari


Description
-------

During Datanode/Nodemanager deletion refreshNodes command is called so the restart for the Namenodes/ResourceManagers is not needed. Same for HBase?


Diffs
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4c20f62 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java 9509608 


Diff: https://reviews.apache.org/r/61177/diff/1/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen


Re: Review Request 61177: Don't set restart indicators for NN/RM during DN/NM deletion

Posted by Sid Wagle <sw...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61177/#review181576
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On July 27, 2017, 1:26 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61177/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 1:26 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-21587
>     https://issues.apache.org/jira/browse/AMBARI-21587
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> During Datanode/Nodemanager deletion refreshNodes command is called so the restart for the Namenodes/ResourceManagers is not needed. Same for HBase?
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4c20f62 
>   ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9 
> 
> 
> Diff: https://reviews.apache.org/r/61177/diff/2/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>


Re: Review Request 61177: Don't set restart indicators for NN/RM during DN/NM deletion

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61177/
-----------------------------------------------------------

(Updated Июль 27, 2017, 1:26 п.п.)


Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.


Bugs: AMBARI-21587
    https://issues.apache.org/jira/browse/AMBARI-21587


Repository: ambari


Description
-------

During Datanode/Nodemanager deletion refreshNodes command is called so the restart for the Namenodes/ResourceManagers is not needed. Same for HBase?


Diffs (updated)
-----

  ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java 4c20f62 
  ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java fc42ff9 


Diff: https://reviews.apache.org/r/61177/diff/2/

Changes: https://reviews.apache.org/r/61177/diff/1-2/


Testing
-------

Unit tests passed


Thanks,

Dmytro Sen