You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/09/21 06:21:06 UTC

[GitHub] [shardingsphere] victorzhangchn edited a comment on issue #7482: Add CircuitBreak function for PostgreSQL proxy

victorzhangchn edited a comment on issue #7482:
URL: https://github.com/apache/shardingsphere/issues/7482#issuecomment-695923046


   > Please FIY MySQL proxy's implementation on `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor`
   
   I'm confusing that the code about CircuitBreak in both `MySQLComStmtExecuteExecutor` and `MySQLComQueryPacketExecutor` is just throw CircuitBreakException, and then wrap it at the outer layer. What do you actually want me to do in this issue? Just throw  CircuitBreakException in `PostgreSQLComExecuteExecutor` and `PostgreSQLComQueryExecutor`? By the way, I find that the behaviour of `PostgreSQLComBindExecutor` does not match the command `BIND` of  protocol of PostgreSQL. @menghaoranss @terrymanu 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org