You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <be...@mesosphere.io> on 2019/03/03 12:29:10 UTC
Review Request 70104: Fixed broken Yaml in contributors database.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Fixed broken Yaml in contributors database.
Diffs
-----
docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad
Diff: https://reviews.apache.org/r/70104/diff/1/
Testing
-------
* without this patch the changed file fails to validate with pyyaml
* with this patch all yaml files in the source tree validate with pyyaml
Thanks,
Benjamin Bannier
Re: Review Request 70104: Fixed broken Yaml in contributors database.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/#review213384
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On March 3, 2019, 4:29 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70104/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 4:29 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also removes the executable bit on this file which was
> added in the same commit as the invalid Yaml.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad
>
>
> Diff: https://reviews.apache.org/r/70104/diff/2/
>
>
> Testing
> -------
>
> * without this patch the changed file fails to validate with pyyaml
> * with this patch all yaml files in the source tree validate with pyyaml
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 70104: Fixed broken Yaml in contributors database.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70104/#review213377
-----------------------------------------------------------
Patch looks great!
Reviews applied: [70104]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On March 3, 2019, 1:29 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70104/
> -----------------------------------------------------------
>
> (Updated March 3, 2019, 1:29 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch also removes the executable bit on this file which was
> added in the same commit as the invalid Yaml.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 171c09118c5c4847660db6cb035dba821c5d92ad
>
>
> Diff: https://reviews.apache.org/r/70104/diff/2/
>
>
> Testing
> -------
>
> * without this patch the changed file fails to validate with pyyaml
> * with this patch all yaml files in the source tree validate with pyyaml
>
>
> Thanks,
>
> Benjamin Bannier
>
>