[GitHub] [incubator-nuttx] GUIDINGLI commented on a change in pull request #4759: mm: do kmm_checkcorruption in IRQ when TCB_FLAG_DEBUG_CHECK set

[GitBox <gi...@apache.org>]

GUIDINGLI commented on a change in pull request #4759:
URL: https://github.com/apache/incubator-nuttx/pull/4759#discussion_r743436110



##########
File path: sched/irq/irq_dispatch.c
##########
@@ -184,6 +185,14 @@ void irq_dispatch(int irq, FAR void *context)
   sched_note_irqhandler(irq, vector, false);
 #endif
 
+#ifdef CONFIG_DEBUG_MM
+  if ((g_running_tasks[this_cpu()]->flags & TCB_FLAG_MEM_CHECK) || \
+       (this_task()->flags & TCB_FLAG_MEM_CHECK))
+    {
+      kmm_checkcorruption();

Review comment:
       Yes, you are right,
   
   For example:
   thread1 -> thread2 -> thread3 -> idle -> thread4 -> crash
   overwrite
   
   If just check in idle, then can't get the "killer" as early as possible.
   With this method, then we can check the "killer" at each context_switch.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org