You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@red-bean.com> on 2007/09/14 06:15:16 UTC
Re: svn commit: r26586 - branches/ancestry-walk/subversion/libsvn_repos
hwright@tigris.org writes:
> --- branches/ancestry-walk/subversion/libsvn_repos/rev_hunt.c (original)
> +++ branches/ancestry-walk/subversion/libsvn_repos/rev_hunt.c Thu Sep 13 20:49:24 2007
> @@ -205,7 +205,42 @@
> start, end, cross_copies, pool);
> }
>
> +/* Baton for svn_repos_history2() */
> +struct history_cb_baton
> +{
> + svn_repos_history_func_t history_func;
> + void *history_baton;
> +};
> +
> +/* Callback for ancestry walking in svn_repos_history2(). */
> +static svn_error_t *
> +history_ancestor(void *baton,
> + const char *path,
> + svn_revnum_t rev,
> + svn_boolean_t is_merge,
> + svn_boolean_t *halt,
> + apr_pool_t *pool)
> +{
I think when we implement a named type, we generally say so:
"Implements the 'svn_foo_bar_baz_t' interface" or whatever.
-K
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r26586 - branches/ancestry-walk/subversion/libsvn_repos
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Karl Fogel wrote:
> hwright@tigris.org writes:
>> --- branches/ancestry-walk/subversion/libsvn_repos/rev_hunt.c (original)
>> +++ branches/ancestry-walk/subversion/libsvn_repos/rev_hunt.c Thu Sep 13 20:49:24 2007
>> @@ -205,7 +205,42 @@
>> start, end, cross_copies, pool);
>> }
>>
>> +/* Baton for svn_repos_history2() */
>> +struct history_cb_baton
>> +{
>> + svn_repos_history_func_t history_func;
>> + void *history_baton;
>> +};
>> +
>> +/* Callback for ancestry walking in svn_repos_history2(). */
>> +static svn_error_t *
>> +history_ancestor(void *baton,
>> + const char *path,
>> + svn_revnum_t rev,
>> + svn_boolean_t is_merge,
>> + svn_boolean_t *halt,
>> + apr_pool_t *pool)
>> +{
>
> I think when we implement a named type, we generally say so:
> "Implements the 'svn_foo_bar_baz_t' interface" or whatever.
Done in r26596. Thanks!
- -Hyrum
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFG6qmdCwOubk4kUXwRAg7MAKCkZmgOdO8XaRhGFZYJa0QVKpDVqACgqJ6G
g3dtr17uxOArAJUauzG/xG8=
=hzvv
-----END PGP SIGNATURE-----
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org