You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "mufiye (via GitHub)" <gi...@apache.org> on 2023/03/01 13:40:05 UTC
[GitHub] [dubbo-samples] mufiye opened a new pull request, #756: Dubbo-samples-stub Refactor to springboot style
mufiye opened a new pull request, #756:
URL: https://github.com/apache/dubbo-samples/pull/756
change the 2-advanced dubbo-samples-stub code "spring xml style" to "spring boot style". Wish to be reviewed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj merged pull request #756: Dubbo-samples-stub Refactor to springboot style
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #756:
URL: https://github.com/apache/dubbo-samples/pull/756
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] mufiye commented on pull request #756: Dubbo-samples-stub Refactor to springboot style
Posted by "mufiye (via GitHub)" <gi...@apache.org>.
mufiye commented on PR #756:
URL: https://github.com/apache/dubbo-samples/pull/756#issuecomment-1451172211
I have checked the workflow results, and I find that many other modules fail but I think I don't change them. For my dubbo-samples-stub module, I run its integration test locally with 3.2.0-beta.4 successfully. But if run with 3.2.0-beta.5, the below error will appear.
```
java.lang.IllegalStateException: Extension instance (name: observationreceiver, class: interface org.apache.dubbo.rpc.Filter) couldn't be instantiated: null
at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:826)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:575)
at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:549)
at org.apache.dubbo.common.extension.ExtensionLoader.lambda$getActivateExtension$4(ExtensionLoader.java:398)
at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:721)
at java.base/java.util.Collections$SynchronizedMap.forEach(Collections.java:2735)
at org.apache.dubbo.common.extension.ExtensionLoader.getActivateExtension(ExtensionLoader.java:393)
at org.apache.dubbo.common.extension.ExtensionLoader.getActivateExtension(ExtensionLoader.java:331)
at org.apache.dubbo.rpc.cluster.filter.DefaultFilterChainBuilder.buildInvokerChain(DefaultFilterChainBuilder.java:50)
at org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.export(ProtocolFilterWrapper.java:61)
at org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.export(ProtocolSerializationWrapper.java:47)
at org.apache.dubbo.rpc.Protocol$Adaptive.export(Protocol$Adaptive.java)
at org.apache.dubbo.config.ServiceConfig.doExportUrl(ServiceConfig.java:738)
at org.apache.dubbo.config.ServiceConfig.exportLocal(ServiceConfig.java:754)
at org.apache.dubbo.config.ServiceConfig.exportUrl(ServiceConfig.java:640)
at org.apache.dubbo.config.ServiceConfig.doExportUrlsFor1Protocol(ServiceConfig.java:450)
at org.apache.dubbo.config.ServiceConfig.doExportUrls(ServiceConfig.java:432)
at org.apache.dubbo.config.ServiceConfig.doExport(ServiceConfig.java:394)
at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:246)
at org.apache.dubbo.config.deploy.DefaultModuleDeployer.exportServiceInternal(DefaultModuleDeployer.java:350)
at org.apache.dubbo.config.deploy.DefaultModuleDeployer.exportServices(DefaultModuleDeployer.java:322)
at org.apache.dubbo.config.deploy.DefaultModuleDeployer.startSync(DefaultModuleDeployer.java:158)
at org.apache.dubbo.config.deploy.DefaultModuleDeployer.start(DefaultModuleDeployer.java:139)
at org.apache.dubbo.config.spring.context.DubboDeployApplicationListener.onContextRefreshedEvent(DubboDeployApplicationListener.java:113)
at org.apache.dubbo.config.spring.context.DubboDeployApplicationListener.onApplicationEvent(DubboDeployApplicationListener.java:102)
at org.apache.dubbo.config.spring.context.DubboDeployApplicationListener.onApplicationEvent(DubboDeployApplicationListener.java:47)
at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:176)
at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:169)
at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:143)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:413)
at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:370)
at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:935)
at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:587)
at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:730)
at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:432)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:308)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1302)
at org.springframework.boot.SpringApplication.run(SpringApplication.java:1291)
at org.apache.dubbo.samples.stub.provider.StubProvider.main(StubProvider.java:33)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on pull request #756: Dubbo-samples-stub Refactor to springboot style
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on PR #756:
URL: https://github.com/apache/dubbo-samples/pull/756#issuecomment-1452859122
> I have checked the workflow results, and I find that many other modules fail but I think I don't change them. For my dubbo-samples-stub module, I run its integration test locally with 3.2.0-beta.4 successfully. But if run with 3.2.0-beta.5, the below error will appear.
>
> ```java
> java.lang.IllegalStateException: Extension instance (name: observationreceiver, class: interface org.apache.dubbo.rpc.Filter) couldn't be instantiated: null
> at org.apache.dubbo.common.extension.ExtensionLoader.createExtension(ExtensionLoader.java:826)
> at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:575)
> at org.apache.dubbo.common.extension.ExtensionLoader.getExtension(ExtensionLoader.java:549)
> at org.apache.dubbo.common.extension.ExtensionLoader.lambda$getActivateExtension$4(ExtensionLoader.java:398)
> at java.base/java.util.LinkedHashMap.forEach(LinkedHashMap.java:721)
> at java.base/java.util.Collections$SynchronizedMap.forEach(Collections.java:2735)
> at org.apache.dubbo.common.extension.ExtensionLoader.getActivateExtension(ExtensionLoader.java:393)
> at org.apache.dubbo.common.extension.ExtensionLoader.getActivateExtension(ExtensionLoader.java:331)
> at org.apache.dubbo.rpc.cluster.filter.DefaultFilterChainBuilder.buildInvokerChain(DefaultFilterChainBuilder.java:50)
> at org.apache.dubbo.rpc.cluster.filter.ProtocolFilterWrapper.export(ProtocolFilterWrapper.java:61)
> at org.apache.dubbo.rpc.protocol.ProtocolSerializationWrapper.export(ProtocolSerializationWrapper.java:47)
> at org.apache.dubbo.rpc.Protocol$Adaptive.export(Protocol$Adaptive.java)
> at org.apache.dubbo.config.ServiceConfig.doExportUrl(ServiceConfig.java:738)
> at org.apache.dubbo.config.ServiceConfig.exportLocal(ServiceConfig.java:754)
> at org.apache.dubbo.config.ServiceConfig.exportUrl(ServiceConfig.java:640)
> at org.apache.dubbo.config.ServiceConfig.doExportUrlsFor1Protocol(ServiceConfig.java:450)
> at org.apache.dubbo.config.ServiceConfig.doExportUrls(ServiceConfig.java:432)
> at org.apache.dubbo.config.ServiceConfig.doExport(ServiceConfig.java:394)
> at org.apache.dubbo.config.ServiceConfig.export(ServiceConfig.java:246)
> at org.apache.dubbo.config.deploy.DefaultModuleDeployer.exportServiceInternal(DefaultModuleDeployer.java:350)
> at org.apache.dubbo.config.deploy.DefaultModuleDeployer.exportServices(DefaultModuleDeployer.java:322)
> at org.apache.dubbo.config.deploy.DefaultModuleDeployer.startSync(DefaultModuleDeployer.java:158)
> at org.apache.dubbo.config.deploy.DefaultModuleDeployer.start(DefaultModuleDeployer.java:139)
> at org.apache.dubbo.config.spring.context.DubboDeployApplicationListener.onContextRefreshedEvent(DubboDeployApplicationListener.java:113)
> at org.apache.dubbo.config.spring.context.DubboDeployApplicationListener.onApplicationEvent(DubboDeployApplicationListener.java:102)
> at org.apache.dubbo.config.spring.context.DubboDeployApplicationListener.onApplicationEvent(DubboDeployApplicationListener.java:47)
> at org.springframework.context.event.SimpleApplicationEventMulticaster.doInvokeListener(SimpleApplicationEventMulticaster.java:176)
> at org.springframework.context.event.SimpleApplicationEventMulticaster.invokeListener(SimpleApplicationEventMulticaster.java:169)
> at org.springframework.context.event.SimpleApplicationEventMulticaster.multicastEvent(SimpleApplicationEventMulticaster.java:143)
> at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:413)
> at org.springframework.context.support.AbstractApplicationContext.publishEvent(AbstractApplicationContext.java:370)
> at org.springframework.context.support.AbstractApplicationContext.finishRefresh(AbstractApplicationContext.java:935)
> at org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:587)
> at org.springframework.boot.SpringApplication.refresh(SpringApplication.java:730)
> at org.springframework.boot.SpringApplication.refreshContext(SpringApplication.java:432)
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:308)
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:1302)
> at org.springframework.boot.SpringApplication.run(SpringApplication.java:1291)
> at org.apache.dubbo.samples.stub.provider.StubProvider.main(StubProvider.java:33)
> ```
Yes, it's caused by other changes in apache/dubbo repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-samples] chickenlj commented on a diff in pull request #756: Dubbo-samples-stub Refactor to springboot style
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj commented on code in PR #756:
URL: https://github.com/apache/dubbo-samples/pull/756#discussion_r1123965904
##########
2-advanced/dubbo-samples-stub/dubbo-samples-stub-provider/src/main/java/org/apache/dubbo/samples/stub/provider/StubProvider.java:
##########
@@ -17,19 +17,20 @@
*
*/
-package org.apache.dubbo.samples.stub;
+package org.apache.dubbo.samples.stub.provider;
-import org.springframework.context.support.ClassPathXmlApplicationContext;
+import org.apache.dubbo.config.spring.context.annotation.EnableDubbo;
+
+import org.springframework.boot.SpringApplication;
+import org.springframework.boot.autoconfigure.SpringBootApplication;
import java.util.concurrent.CountDownLatch;
+@SpringBootApplication
+@EnableDubbo
public class StubProvider {
-
public static void main(String[] args) throws Exception {
- new EmbeddedZooKeeper(2181, false).start();
Review Comment:
Keeping an embedded zookeeper would make it easier for users to use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org