You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/05/08 18:21:42 UTC

[GitHub] mistercrunch opened a new pull request #4961: Deprecate database attribute allow_run_sync

mistercrunch opened a new pull request #4961: Deprecate database attribute allow_run_sync
URL: https://github.com/apache/incubator-superset/pull/4961
 
 
   There's really 2 modes of operations in SQL Lab, sync or async
   though currently there are 2 boolean flags: allow_run_sync and
   allow_run_async, leading to 4 potential combinations, only 2 of which
   actually makes sense.
   
   The original vision is that we'd expose the choice to users and they
   would decide which `Run` or `Run Async` button to hit.
   Later on we decided to have a
   single button and for each database to be either sync or async.
   
   This PR cleans up allow_run_sync by removing references to it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org