You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by gr...@apache.org on 2021/02/26 21:58:34 UTC
[royale-asjs] branch develop updated (d247ab7 -> a9558aa)
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a change to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git.
from d247ab7 jewel-tilelayouts: perform layout when changed at runtime 2
new 449cf4a Formatting tidyup and avoid duplicate var declaration warning
new a9558aa reduce build noise, avoid warnings for (presumably) intentional 'this within closure' usage (matches maven build)
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../projects/MXRoyaleJS/src/main/config/compile-js-config.xml | 3 +++
.../projects/MXRoyale/src/main/config/compile-swf-config.xml | 3 +++
.../listClasses/VirtualDataItemRendererFactoryForIListData.as | 11 ++++++-----
3 files changed, 12 insertions(+), 5 deletions(-)
[royale-asjs] 01/02: Formatting tidyup and avoid duplicate var
declaration warning
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit 449cf4a5da2860c65ecd7c4feb932bb7e8193b9b
Author: greg-dove <gr...@gmail.com>
AuthorDate: Sat Feb 27 10:44:35 2021 +1300
Formatting tidyup and avoid duplicate var declaration warning
---
.../listClasses/VirtualDataItemRendererFactoryForIListData.as | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForIListData.as b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForIListData.as
index 6f7db55..9fc01ff 100644
--- a/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForIListData.as
+++ b/frameworks/projects/MXRoyale/src/main/royale/mx/controls/listClasses/VirtualDataItemRendererFactoryForIListData.as
@@ -143,21 +143,22 @@ package mx.controls.listClasses
var ir:IIndexedItemRenderer = rendererMap[index];
if (ir) return ir;
- var functionBead:ItemRendererFunctionBead = _strand.getBeadByType(ItemRendererFunctionBead) as ItemRendererFunctionBead;
- var rendererFunction:Function = functionBead ? functionBead.itemRendererFunction : null;
+ var functionBead:ItemRendererFunctionBead = _strand.getBeadByType(ItemRendererFunctionBead) as ItemRendererFunctionBead;
+ var rendererFunction:Function = functionBead ? functionBead.itemRendererFunction : null;
var dp:IList = dataProviderModel.dataProvider as IList;
var view:IListView = (_strand as IStrandWithModelView).view as IListView;
var dataGroup:IItemRendererOwnerView = view.dataGroup;
var data:Object = dp.getItemAt(index);
- var ir:IIndexedItemRenderer = rendererFunction ? (rendererFunction(data) as IFactory).newInstance() as IIndexedItemRenderer :
- itemRendererFactory.createItemRenderer() as IIndexedItemRenderer;
+ ir = rendererFunction ?
+ (rendererFunction(data) as IFactory).newInstance() as IIndexedItemRenderer :
+ itemRendererFactory.createItemRenderer() as IIndexedItemRenderer;
dataGroup.addItemRendererAt(ir, elementIndex);
(itemRendererInitializer as IIndexedItemRendererInitializer).initializeIndexedItemRenderer(ir, data, index);
rendererMap[index] = ir;
- ir.data = data;
+ ir.data = data;
var newEvent:ItemRendererEvent = new ItemRendererEvent(ItemRendererEvent.CREATED);
newEvent.itemRenderer = ir;
[royale-asjs] 02/02: reduce build noise,
avoid warnings for (presumably) intentional 'this within closure'
usage (matches maven build)
Posted by gr...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
gregdove pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git
commit a9558aa928390357c7e8e77ff9cc126c35b6a794
Author: greg-dove <gr...@gmail.com>
AuthorDate: Sat Feb 27 10:57:54 2021 +1300
reduce build noise, avoid warnings for (presumably) intentional 'this within closure' usage (matches maven build)
---
.../js/projects/MXRoyaleJS/src/main/config/compile-js-config.xml | 3 +++
frameworks/projects/MXRoyale/src/main/config/compile-swf-config.xml | 3 +++
2 files changed, 6 insertions(+)
diff --git a/frameworks/js/projects/MXRoyaleJS/src/main/config/compile-js-config.xml b/frameworks/js/projects/MXRoyaleJS/src/main/config/compile-js-config.xml
index ba023db..e906ba0 100644
--- a/frameworks/js/projects/MXRoyaleJS/src/main/config/compile-js-config.xml
+++ b/frameworks/js/projects/MXRoyaleJS/src/main/config/compile-js-config.xml
@@ -91,6 +91,9 @@
<!-- Use of the instanceof operator. -->
<warn-instance-of-changes>false</warn-instance-of-changes>
+
+ <!-- avoid warnings for 'this within closure' (multiple, intentional) -->
+ <warn-this-within-closure>false</warn-this-within-closure>
</compiler>
<export-protected-symbols>true</export-protected-symbols>
diff --git a/frameworks/projects/MXRoyale/src/main/config/compile-swf-config.xml b/frameworks/projects/MXRoyale/src/main/config/compile-swf-config.xml
index 62e8da4..06d5442 100644
--- a/frameworks/projects/MXRoyale/src/main/config/compile-swf-config.xml
+++ b/frameworks/projects/MXRoyale/src/main/config/compile-swf-config.xml
@@ -96,6 +96,9 @@
<!-- Use of the instanceof operator. -->
<warn-instance-of-changes>false</warn-instance-of-changes>
+
+ <!-- avoid warnings for 'this within closure' (multiple, intentional) -->
+ <warn-this-within-closure>false</warn-this-within-closure>
</compiler>
<include-file>