You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/05/20 08:01:46 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6303: MPFS: Implement S-mode head and start function

xiaoxiang781216 commented on code in PR #6303:
URL: https://github.com/apache/incubator-nuttx/pull/6303#discussion_r877856797


##########
arch/risc-v/src/mpfs/mpfs_head.S:
##########
@@ -100,30 +100,17 @@ __start:
   csrr a0, mhartid
   beqz a0, .skip_e51
 
-  /* Clear sscratch if u54 */
-
-  csrw sscratch, zero

Review Comment:
   one simple question: why not use #ifdef/#else/#endif to separate M-mode or S-mode specific code?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org