[jira] [Commented] (FINERACT-747) Performance updates : change String.replaceAll() to replace() if the replaced one is plain string.

["Michael Vorburger (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FINERACT-747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17103004#comment-17103004 ] 

Michael Vorburger commented on FINERACT-747:
--------------------------------------------

[~bd2019us] FYI you can now assign issues to yourself in this JIRA.

> Performance updates : change String.replaceAll() to replace() if the replaced one is plain string.
> --------------------------------------------------------------------------------------------------
>
>                 Key: FINERACT-747
>                 URL: https://issues.apache.org/jira/browse/FINERACT-747
>             Project: Apache Fineract
>          Issue Type: Improvement
>            Reporter: bd2019us
>            Assignee: bd2019us
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.4.0
>
>         Attachments: 1.patch
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Locations: 
> (1) fineract-provider/src/main/java/org/apache/fineract/accounting/rule/api/AccountingRuleJsonInputParams.java
> (2) fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/fixeddeposits/
> FixedDepositTransactionWorkbookPopulator.java
> (3) fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/loanrepayment/LoanRepaymentWorkbookPopulator.java
> (4) fineract-provider/src/main/java/org/apache/fineract/infrastructure/bulkimport/populator/savings/SavingsTransactionsWorkbookPopulator.java
> (5) fineract-provider/src/main/java/org/apache/fineract/portfolio/common/domain/ConditionType.java
> (6) fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/CenterReadPlatformServiceImpl.java
> (7) fineract-provider/src/main/java/org/apache/fineract/portfolio/group/service/GroupReadPlatformServiceImpl.java
> (8) fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanReadPlatformServiceImpl.java
>  
> The String.replaceAll(regex, other) is usually used to replace strings represented by regular expression "regex". When the replaced string is a plain string but regex form, the String.replace(origin, other) is recommended as it does not need to compile and can improve the performance.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)