You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/17 15:25:17 UTC
[GitHub] [druid] prabcs opened a new pull request #9209:
[Extensions][Google] Add details about the keyfile
prabcs opened a new pull request #9209: [Extensions][Google] Add details about the keyfile
URL: https://github.com/apache/druid/pull/9209
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
<!-- Describe the goal of this PR, what problem are you fixing. If there is a corresponding issue (referenced above), it's not necessary to repeat the description here, however, you may choose to keep one summary sentence. -->
Setting up Druid on GCP needs druid processes to start with `GOOGLE_APPLICATION_CREDENTIALS=<path to service account key file>` in the environment.
After learning this the hard way, this PR adds this detail to the docs.
<!-- Describe your patch: what did you change in code? How did you fix the problem? -->
<!-- If there are several relatively logically separate changes in this PR, create a mini-section for each of them. For example: -->
<hr>
This PR has:
- [x] been self-reviewed.
- [x] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #9209: [Extensions][Google]
Add details about the keyfile
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #9209: [Extensions][Google] Add details about the keyfile
URL: https://github.com/apache/druid/pull/9209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] prabcs commented on a change in pull request #9209:
[Extensions][Google] Add details about the keyfile
Posted by GitBox <gi...@apache.org>.
prabcs commented on a change in pull request #9209: [Extensions][Google] Add details about the keyfile
URL: https://github.com/apache/druid/pull/9209#discussion_r367992248
##########
File path: docs/development/extensions-core/google.md
##########
@@ -23,7 +23,7 @@ title: "Google Cloud Storage"
-->
-To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension.
+To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension and run druid processes with `GOOGLE_APPLICATION_CREDENTIALS=/path/to/service_account_keyfile` in the environment.
Review comment:
Question to reviewers: Do all druid processes need this or just the ones that are talking to GCS ??
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on a change in pull request #9209:
[Extensions][Google] Add details about the keyfile
Posted by GitBox <gi...@apache.org>.
jihoonson commented on a change in pull request #9209: [Extensions][Google] Add details about the keyfile
URL: https://github.com/apache/druid/pull/9209#discussion_r368097426
##########
File path: docs/development/extensions-core/google.md
##########
@@ -23,7 +23,7 @@ title: "Google Cloud Storage"
-->
-To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension.
+To use this Apache Druid extension, make sure to [include](../../development/extensions.md#loading-extensions) `druid-google-extensions` extension and run druid processes with `GOOGLE_APPLICATION_CREDENTIALS=/path/to/service_account_keyfile` in the environment.
Review comment:
I think you can set it for ones only who talk to GCS which are middleManagers, indexers, and historicals. But I guess setting this in all nodes doesn't harm as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org