You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Hudson (Jira)" <ji...@apache.org> on 2020/01/26 23:17:03 UTC
[jira] [Commented] (MNG-6720) MultiThreadedBuilder: wait for
parallel running projects when using --fail-fast
[ https://issues.apache.org/jira/browse/MNG-6720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17023988#comment-17023988 ]
Hudson commented on MNG-6720:
-----------------------------
Build succeeded in Jenkins: Maven TLP » maven » MNG-6071 #33
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6071/33/
> MultiThreadedBuilder: wait for parallel running projects when using --fail-fast
> -------------------------------------------------------------------------------
>
> Key: MNG-6720
> URL: https://issues.apache.org/jira/browse/MNG-6720
> Project: Maven
> Issue Type: Bug
> Components: core
> Affects Versions: 3.5.4, 3.6.1
> Reporter: Stefan Oehme
> Assignee: Michael Osipov
> Priority: Major
> Fix For: 3.6.2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When a project fails using --fail-fast mode, other projects that are currently running in parallel are not finished before the "session finished" event is sent. This leads to issues for extensions that rely on the documented order of events, which says that "session finished" is only sent "after all projects have been finished/skipped".
> In our case, we close a service on "session finished", and that service is needed to execute goals. The goals that were running in parallel at that time then fail, saying that our service was closed, giving our users the impression that there is a bug in our code.
> The relevant line is [here|https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/lifecycle/internal/builder/multithreaded/MultiThreadedBuilder.java#L179]. Instead of using `poll`, which simply returns when the parallel projects aren't finished yet, the code should shut down the executor and wait for it to complete the outstanding parallel work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)