You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by spmallette <gi...@git.apache.org> on 2018/06/21 21:27:07 UTC
[GitHub] tinkerpop pull request #883: TINKERPOP-1864 Run python glv tests on GraphSON...
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/883
TINKERPOP-1864 Run python glv tests on GraphSON 2.0 and 3.0
https://issues.apache.org/jira/browse/TINKERPOP-1864
There was about a 10 second time increase for adding the additional test execution option. Seems worthwhile.
Builds with `mvn clean install -pl gremlin-python`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1864
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/883.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #883
----
commit 6bd3199967608b8f1fd66ac1c72ccbbce7b76418
Author: Stephen Mallette <sp...@...>
Date: 2018-06-21T21:24:58Z
TINKERPOP-1864 Run python glv tests on GraphSON 2.0 and 3.0
There was about a 10 second time increase for adding the additional test execution option. Seems worthwhile.
----
---
[GitHub] tinkerpop pull request #883: TINKERPOP-1864 Run python glv tests on GraphSON...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/883
---
[GitHub] tinkerpop issue #883: TINKERPOP-1864 Run python glv tests on GraphSON 2.0 an...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/883
That's fair - changed now so that you get this if "graphson" isn't set:
```text
[exec] Error: Hook 'prepare_traversal_source' from /home/smallette/git/apache/incubator-tinkerpop/gremlin-python/target/python2/radish/terrain.py:66 raised: 'ValueError: test configuration requires setting of --user-data="graphson=*" to one of [v2,v3]'
[exec]
[exec] Traceback (most recent call last):
[exec] File "/home/smallette/git/apache/incubator-tinkerpop/gremlin-python/target/python2/env/local/lib/python2.7/site-packages/radish/hookregistry.py", line 121, in call
[exec] func(model, *args, **kwargs)
[exec] File "/home/smallette/git/apache/incubator-tinkerpop/gremlin-python/target/python2/radish/terrain.py", line 70, in prepare_traversal_source
[exec] raise ValueError('test configuration requires setting of --user-data="graphson=*" to one of [v2,v3]')
[exec] ValueError: test configuration requires setting of --user-data="graphson=*" to one of [v2,v3]
```
also, if you don't have a good value for "graphson" then you get:
```text
[exec] Error: Hook 'prepare_traversal_source' from /home/smallette/git/apache/incubator-tinkerpop/gremlin-python/target/python2/radish/terrain.py:66 raised: 'ValueError: serializer set with --user-data="graphson=v2" must be one of [v2,v3]'
[exec]
[exec] Traceback (most recent call last):
[exec] File "/home/smallette/git/apache/incubator-tinkerpop/gremlin-python/target/python2/env/local/lib/python2.7/site-packages/radish/hookregistry.py", line 121, in call
[exec] func(model, *args, **kwargs)
[exec] File "/home/smallette/git/apache/incubator-tinkerpop/gremlin-python/target/python2/radish/terrain.py", line 77, in prepare_traversal_source
[exec] raise ValueError('serializer set with --user-data="graphson=v2" must be one of [v2,v3]')
[exec] ValueError: serializer set with --user-data="graphson=v2" must be one of [v2,v3]
```
---
[GitHub] tinkerpop issue #883: TINKERPOP-1864 Run python glv tests on GraphSON 2.0 an...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/883
VOTE: +1
... but maybe make the configuration mandatory and throw an exception if ` world.config.user_data["graphson"]` was not set.
---