You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/05/31 12:57:07 UTC

[GitHub] [couchdb] iilyak commented on a change in pull request #3587: Do not warn for invalid offset with spidermonkey 60 on mac

iilyak commented on a change in pull request #3587:
URL: https://github.com/apache/couchdb/pull/3587#discussion_r642469416



##########
File path: src/couch/rebar.config.script
##########
@@ -126,7 +126,7 @@ end.
         };
     {unix, darwin} when SMVsn == "60" ->
         {
-            "-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14",
+            "-DXP_UNIX -I/usr/include/mozjs-60 -I/usr/local/include/mozjs-60 -std=c++14 -Wno-invalid-offsetof",

Review comment:
       The `no-invalid-offsetof` is needed because version we use doesn't configure it properly (see [where it was finally autoconfigured](https://github.com/mozilla/gecko-dev/commit/6d93e1b2e447a48303fcec5b10941f2143f625d1#diff-bb21aa33a3f69ccb36c68b220f40ad08f29b9cd2c05dfedae7b9e3d5d4d08f6bL1599)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org