You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/09/23 14:13:10 UTC
[GitHub] [druid] senthilkv opened a new pull request #10424: This enhances RequestLog for audit and debugging to log status change such as POST/DELETE/UPDATE
senthilkv opened a new pull request #10424:
URL: https://github.com/apache/druid/pull/10424
his PR Describes changes applied to the Requestlog.
This enhances RequestLog for audit and debugging. The Requestlog has been updated to capture state changing api calls such as (POST/DELETE/UPDATE), so that this can be used to audit, debugging logs in order to identify who, what , when. The code has been tested on our internal clusters. The log generated is presented as follows
xx.xx.xx.xx DELETE https://druid-coord.xxxxxx.comm:4443/druid/coordinator/v1/datasources/testdata_A1M_02_01 HTTP/1.1
xx.xx.xx.xx POST https://druid-coord.xxxxxx.com:4443/druid/coordinator/v1/datasources/testdata_A1M_02_02/markUnused HTTP/1.1
If the community feels that it is too much to capture these details , in future we can provide updates to capture in a separate file.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/licenses.yaml)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [x] been tested in a test Druid cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist above are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
<hr>
##### Key changed/added classes in this PR
* Requestlog
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] senthilkv closed pull request #10424: This enhances RequestLog for audit and debugging to log status change such as POST/DELETE/UPDATE
Posted by GitBox <gi...@apache.org>.
senthilkv closed pull request #10424:
URL: https://github.com/apache/druid/pull/10424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] senthilkv closed pull request #10424: This enhances RequestLog for audit and debugging to log status change such as POST/DELETE/UPDATE
Posted by GitBox <gi...@apache.org>.
senthilkv closed pull request #10424:
URL: https://github.com/apache/druid/pull/10424
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] senthilkv commented on pull request #10424: This enhances RequestLog for audit and debugging to log status change such as POST/DELETE/UPDATE
Posted by GitBox <gi...@apache.org>.
senthilkv commented on pull request #10424:
URL: https://github.com/apache/druid/pull/10424#issuecomment-705754984
need to update the github
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] senthilkv commented on pull request #10424: This enhances RequestLog for audit and debugging to log status change such as POST/DELETE/UPDATE
Posted by GitBox <gi...@apache.org>.
senthilkv commented on pull request #10424:
URL: https://github.com/apache/druid/pull/10424#issuecomment-705754984
need to update the github
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org