You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@impala.apache.org by bo...@apache.org on 2025/04/11 07:21:16 UTC
(impala) 02/04: IMPALA-13932: (addendum) Adds e2e test for IMPALA-13932
This is an automated email from the ASF dual-hosted git repository.
boroknagyz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git
commit 2849708b8701485637478ab6201b0780e80570ca
Author: Zoltan Borok-Nagy <bo...@cloudera.com>
AuthorDate: Thu Apr 10 14:29:55 2025 +0200
IMPALA-13932: (addendum) Adds e2e test for IMPALA-13932
This patch adds e2e test for IMPALA-13932.
Change-Id: I07537b31717d568422ea042ad2aeef906b3cab2e
Reviewed-on: http://gerrit.cloudera.org:8080/22767
Reviewed-by: Peter Rozsa <pr...@cloudera.com>
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
.../QueryTest/iceberg-merge-duplicate-check.test | 20 ++++++++++++++++++++
tests/query_test/test_iceberg.py | 6 ++++++
2 files changed, 26 insertions(+)
diff --git a/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-duplicate-check.test b/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-duplicate-check.test
new file mode 100644
index 000000000..17675e226
--- /dev/null
+++ b/testdata/workloads/functional-query/queries/QueryTest/iceberg-merge-duplicate-check.test
@@ -0,0 +1,20 @@
+====
+---- QUERY
+create table merge_duplicate_check
+partitioned by spec(id)
+stored by iceberg
+tblproperties('format-version'='2') as
+ select id, bigint_col, string_col
+ from functional_parquet.alltypes
+ where id < 1000;
+
+set num_nodes=1;
+set mt_dop=1;
+merge into merge_duplicate_check target using functional.alltypes source on (target.id = source.id)
+when matched then update set target.bigint_col = target.bigint_col + 1;
+select sum(bigint_col) from merge_duplicate_check;
+---- RESULTS
+46000
+---- TYPES
+BIGINT
+====
diff --git a/tests/query_test/test_iceberg.py b/tests/query_test/test_iceberg.py
index c41e5162d..ad13b1dc0 100644
--- a/tests/query_test/test_iceberg.py
+++ b/tests/query_test/test_iceberg.py
@@ -2078,6 +2078,12 @@ class TestIcebergV2Table(IcebergTestSuite):
warehouse_prefix=os.getenv("FILESYSTEM_PREFIX"))
self.run_test_case('QueryTest/iceberg-merge-equality-insert', vector, unique_database)
+ def test_merge_duplicate_check(self, vector, unique_database):
+ """Regression test for IMPALA-13932"""
+ # Remove 'num_nodes' option so we can set it at .test file.
+ vector.unset_exec_option('num_nodes')
+ self.run_test_case('QueryTest/iceberg-merge-duplicate-check', vector, unique_database)
+
def test_cleanup(self, unique_database):
"""Test that all uncommitted files written by Impala are removed from the file
system when a DML commit to an Iceberg table fails, and that the effects of the