[GitHub] [ozone] guohao-rosicky commented on a change in pull request #2860: HDDS-4474. [Ozone-Streaming] Use WriteSmallFile to write small file.

[GitBox <gi...@apache.org>]

guohao-rosicky commented on a change in pull request #2860:
URL: https://github.com/apache/ozone/pull/2860#discussion_r800366033



##########
File path: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/impl/SmallFileStreamDataChannel.java
##########
@@ -0,0 +1,176 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ *  with the License.  You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ *  Unless required by applicable law or agreed to in writing, software
+ *  distributed under the License is distributed on an "AS IS" BASIS,
+ *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ *  See the License for the specific language governing permissions and
+ *  limitations under the License.
+ */
+
+package org.apache.hadoop.ozone.container.keyvalue.impl;
+
+import com.google.common.base.Preconditions;
+import org.apache.hadoop.hdds.protocol.datanode.proto.ContainerProtos;
+import org.apache.hadoop.hdds.ratis.ContainerCommandRequestMessage;
+import org.apache.hadoop.hdds.scm.container.common.helpers.StorageContainerException;
+import org.apache.hadoop.ozone.container.common.helpers.BlockData;
+import org.apache.hadoop.ozone.container.common.helpers.ChunkInfo;
+import org.apache.hadoop.ozone.container.common.helpers.ContainerMetrics;
+import org.apache.hadoop.ozone.container.common.interfaces.Container;
+import org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer;
+import org.apache.hadoop.ozone.container.keyvalue.KeyValueHandler;
+import org.apache.hadoop.ozone.container.keyvalue.interfaces.BlockManager;
+import org.apache.ratis.proto.RaftProtos;
+import org.apache.ratis.thirdparty.com.google.protobuf.ByteString;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import java.io.File;
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import java.util.ArrayList;
+import java.util.LinkedList;
+import java.util.List;
+
+/**
+ * This class is used to get the DataChannel for streaming.
+ */
+class SmallFileStreamDataChannel extends StreamDataChannelBase {
+  public static final Logger LOG =
+      LoggerFactory.getLogger(SmallFileStreamDataChannel.class);
+
+  private final Container kvContainer;
+  private final BlockManager blockManager;
+  private BlockData blockData;
+
+  private final int realLen;
+  private int writeLen = 0;
+  private final List<ByteBuffer> metadata = new ArrayList<>();
+  private int metadataLen = 0;
+  private boolean forceClose = false;
+
+  SmallFileStreamDataChannel(File file, Container container,
+                             BlockManager blockManager, long dataLen,
+                             ContainerMetrics metrics)
+      throws StorageContainerException {
+    super(file, container.getContainerData(), metrics);
+    this.blockManager = blockManager;
+    this.kvContainer = container;
+    this.realLen = (int) dataLen;
+  }
+
+  @Override
+  ContainerProtos.Type getType() {
+    return ContainerProtos.Type.PutSmallFile;
+  }
+
+  @Override
+  public int write(ByteBuffer src) throws IOException {
+    int srcLen = src.capacity();
+
+    if (srcLen == 0) {
+      forceClose = true;
+      return 0;
+    } else if (writeLen + srcLen > realLen) {
+
+      if (metadataLen > 0) {
+        metadataLen += srcLen;
+        metadata.add(src);
+      } else {
+        metadataLen += (writeLen + srcLen - realLen);
+
+        int dataLen = srcLen - metadataLen;
+        byte[] data = new byte[dataLen];
+        src.get(data, 0, dataLen);
+        super.write(ByteBuffer.wrap(data));
+
+        byte[] meta = new byte[metadataLen];
+        src.get(meta, dataLen, metadataLen);
+        metadata.add(ByteBuffer.wrap(meta));
+      }
+    } else {
+      super.write(src);
+    }
+    writeLen += srcLen;
+    return srcLen;
+  }
+
+  private ByteString asByteString() {
+    ByteBuffer buffer = ByteBuffer.allocate(metadataLen);
+    for (ByteBuffer b : metadata) {
+      buffer.put(b);
+    }
+    buffer.flip();
+    return ByteString.copyFrom(buffer);
+  }
+
+  @Override
+  public void close() throws IOException {
+    if (forceClose) {
+      super.close();
+      return;
+    }
+
+    if (writeLen <= realLen || metadataLen <= 0) {
+      String msg = "Put small file write length mismatch realLen: " +
+          realLen + " writeLen: " + writeLen + " metadataLen: " + metadataLen;
+      throw new StorageContainerException(msg,
+          ContainerProtos.Result.PUT_SMALL_FILE_ERROR);
+    }
+
+    ContainerProtos.ContainerCommandRequestProto request =
+        ContainerCommandRequestMessage.toProto(asByteString(), null);
+
+    if (!request.hasPutSmallFile()) {
+      if (LOG.isDebugEnabled()) {
+        LOG.debug("Malformed Put Small File request. trace ID: {}",
+            request.getTraceID());
+      }
+      throw new StorageContainerException("Malformed Put Small File request.",
+          ContainerProtos.Result.PUT_SMALL_FILE_ERROR);
+    }
+
+    ContainerProtos.PutSmallFileRequestProto putSmallFileReq =
+        request.getPutSmallFile();
+
+    ContainerProtos.ChunkInfo chunkInfoProto = putSmallFileReq.getChunkInfo();
+    ChunkInfo chunkInfo = ChunkInfo.getFromProtoBuf(chunkInfoProto);
+    Preconditions.checkNotNull(chunkInfo);
+
+    blockData = BlockData.getFromProtoBuf(
+        putSmallFileReq.getBlock().getBlockData());
+    Preconditions.checkNotNull(blockData);
+
+    List<ContainerProtos.ChunkInfo> chunks = new LinkedList<>();
+    chunks.add(chunkInfoProto);
+    blockData.setChunks(chunks);
+
+    super.close();
+  }
+
+  @Override
+  public void link(RaftProtos.LogEntryProto entry) throws IOException {

Review comment:
       @szetszwo This is used to update the BCSID in blockData




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org