You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Miklos Gergely <mg...@hortonworks.com> on 2017/09/07 20:33:34 UTC

Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/
-----------------------------------------------------------

(Updated Sept. 7, 2017, 8:33 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

configurable file format, compression method


Bugs: AMBARI-21810
    https://issues.apache.org/jira/browse/AMBARI-21810


Repository: ambari


Description
-------

This script allows the user to set an end date, and save all the previous log entries into HDFS or S3


Diffs (updated)
-----

  ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
  ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
  ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java PRE-CREATION 
  ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py PRE-CREATION 


Diff: https://reviews.apache.org/r/61898/diff/5/

Changes: https://reviews.apache.org/r/61898/diff/4-5/


Testing
-------

Tested on local cluster with
- SSL
- kerberos
- interrupted, then restarted script
- HDFS
- S3
- the combinations of the above


Thanks,

Miklos Gergely


Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review185274
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Sept. 12, 2017, 3:30 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2017, 3:30 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
>     https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This script allows the user to set an end date, and save all the previous log entries into HDFS or S3
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/7/
> 
> 
> Testing
> -------
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/
-----------------------------------------------------------

(Updated Sept. 12, 2017, 3:30 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

allow user to add additional filters
allow user to specify the name of the archive
support tar.bz2
generate data with json.dumps
fix typos


Bugs: AMBARI-21810
    https://issues.apache.org/jira/browse/AMBARI-21810


Repository: ambari


Description
-------

This script allows the user to set an end date, and save all the previous log entries into HDFS or S3


Diffs (updated)
-----

  ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
  ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
  ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java PRE-CREATION 
  ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py PRE-CREATION 


Diff: https://reviews.apache.org/r/61898/diff/7/

Changes: https://reviews.apache.org/r/61898/diff/6-7/


Testing
-------

Tested on local cluster with
- SSL
- kerberos
- interrupted, then restarted script
- HDFS
- S3
- the combinations of the above


Thanks,

Miklos Gergely


Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

Posted by Miklos Gergely <mg...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/
-----------------------------------------------------------

(Updated Sept. 7, 2017, 9:56 p.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

use flag to indicate line delimited json file creation


Bugs: AMBARI-21810
    https://issues.apache.org/jira/browse/AMBARI-21810


Repository: ambari


Description
-------

This script allows the user to set an end date, and save all the previous log entries into HDFS or S3


Diffs (updated)
-----

  ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
  ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
  ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java PRE-CREATION 
  ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py PRE-CREATION 


Diff: https://reviews.apache.org/r/61898/diff/6/

Changes: https://reviews.apache.org/r/61898/diff/5-6/


Testing
-------

Tested on local cluster with
- SSL
- kerberos
- interrupted, then restarted script
- HDFS
- S3
- the combinations of the above


Thanks,

Miklos Gergely


Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review184886
-----------------------------------------------------------




ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py
Lines 68 (patched)
<https://reviews.apache.org/r/61898/#comment261085>

    this could be --line-delimited (by default would be the one json per line)


- Oliver Szabo


On Sept. 7, 2017, 8:33 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
>     https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This script allows the user to set an end date, and save all the previous log entries into HDFS or S3
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/5/
> 
> 
> Testing
> -------
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>


Re: Review Request 61898: Create Utility Script to support Solr Collection Data Retention/Purging/Archiving

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61898/#review184889
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On Sept. 7, 2017, 8:33 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61898/
> -----------------------------------------------------------
> 
> (Updated Sept. 7, 2017, 8:33 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo and Robert Nettleton.
> 
> 
> Bugs: AMBARI-21810
>     https://issues.apache.org/jira/browse/AMBARI-21810
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This script allows the user to set an end date, and save all the previous log entries into HDFS or S3
> 
> 
> Diffs
> -----
> 
>   ambari-infra/ambari-infra-solr-client/build.xml 9b8b6cc 
>   ambari-infra/ambari-infra-solr-client/pom.xml 3818aba 
>   ambari-infra/ambari-infra-solr-client/src/main/java/org/apache/ambari/infra/solr/S3Uploader.java PRE-CREATION 
>   ambari-infra/ambari-infra-solr-client/src/main/python/solrDataManager.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/61898/diff/5/
> 
> 
> Testing
> -------
> 
> Tested on local cluster with
> - SSL
> - kerberos
> - interrupted, then restarted script
> - HDFS
> - S3
> - the combinations of the above
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>