[GitHub] [incubator-yunikorn-core] sunilgovind commented on a change in pull request #200: [YUNIKORN-375] Use compatible Prometheus client library

[GitBox <gi...@apache.org>]

sunilgovind commented on a change in pull request #200:
URL: https://github.com/apache/incubator-yunikorn-core/pull/200#discussion_r478105547



##########
File path: go.mod
##########
@@ -23,15 +23,17 @@ go 1.12
 
 require (
 	github.com/apache/incubator-yunikorn-scheduler-interface v0.9.1-0.20200827013520-ec2f681ecb5b
+	github.com/beorn7/perks v1.0.1 // indirect
 	github.com/golang/protobuf v1.4.0 // indirect
 	github.com/gorilla/mux v1.7.3
 	github.com/kr/text v0.2.0 // indirect
 	github.com/looplab/fsm v0.1.0
 	github.com/niemeyer/pretty v0.0.0-20200227124842-a10e7caefd8e // indirect
 	github.com/pkg/errors v0.9.1 // indirect
-	github.com/prometheus/client_golang v1.4.0
+	github.com/prometheus/client_golang v0.9.2

Review comment:
       @yangwwei why are we bumping down the version from a stable 1.x to a 0.x version? if there are compatibility issues, it may get missed behind the scenes. 
   How could we verify that we dont have a breakage?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org