You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/08/17 09:23:39 UTC

[GitHub] [spark] Yikun commented on a diff in pull request #37550: [WIP] Add separate infra image for lint job

Yikun commented on code in PR #37550:
URL: https://github.com/apache/spark/pull/37550#discussion_r947667755


##########
.github/workflows/build_infra_images_cache.yml:
##########
@@ -25,6 +25,7 @@ on:
     - 'master'
     paths:
     - 'dev/infra/Dockerfile'
+    - 'dev/infra/lint.Dockerfile'

Review Comment:
   `Dockerfile.<something>` or `<something>.Dockerfile` are remmomand by docker officially:
   https://github.com/docker/docker.github.io/blob/master/_includes/guides/create-dockerfile.md
   
   It could also be: `Dockerfile.lint`
   
   I don't have much preference between `Dockerfile.lint` and `lint.Dockerfile`, all is ok for me.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org